Dpdk tests: add a test that runs a pod using netdevice together with dpdk. #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
approved
fedepaol
force-pushed
the
dpdkmixeduse
branch
4 times, most recently
from
1e92af0
to
d5841f9
Compare
SchSeba
reviewed
Nov 26, 2020
| execute.BeforeAll(func() { | ||
| createSriovPolicyAndNetworkShared() | ||
| var err error | ||
| dpdkWorkloadPod, err = createDPDKWorkload(nodeSelector, |
There was a problem hiding this comment.
should you clean the old pods before?
There was a problem hiding this comment.
That was done inside createSriovPolicyAndNetworkShared / createSriovPolicyAndNetworkDPDKOnly (as it was before).
Will move the clean function outside, I agree it will improve readability.
fedepaol
force-pushed
the
dpdkmixeduse
branch
from
d5841f9
to
9fa3804
Compare
openshift-ci-robot
added
the
needs-rebase
fedepaol
force-pushed
the
dpdkmixeduse
branch
from
9fa3804
to
d1667b1
Compare
openshift-ci-robot
removed
the
needs-rebase
SchSeba
reviewed
Dec 20, 2020
| }) | ||
|
|
||
| It("Run a regular pod using a vf shared with the dpdk's pf", func() { | ||
| podDefinition := pods.DefineWithNetworks(namespaces.DpdkTest, []string{"test-regular-network"}) |
There was a problem hiding this comment.
nit: can use add the network name as const and reuse it in the createSriovPolicyAndNetworkShared function?
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
fedepaol
force-pushed
the
dpdkmixeduse
branch
from
d1667b1
to
47e5300
Compare
fedepaol
force-pushed
the
dpdkmixeduse
branch
from
47e5300
to
5d4861c
Compare
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
fedepaol
force-pushed
the
dpdkmixeduse
branch
from
5d4861c
to
b9b4784
Compare
|
/retest |
fedepaol
force-pushed
the
dpdkmixeduse
branch
from
b9b4784
to
966b18c
Compare
…dpdk. This uses the sriov device partitioning, assigning some vfs to the dpdk payload and some others to pods using net devices. Also, changes the num of hugepages to 5 as 4 are needed to the two dpdk pods, one to the regular pod. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
fedepaol
force-pushed
the
dpdkmixeduse
branch
from
966b18c
to
e5e9d2d
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fedepaol, SchSeba The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the sriov device partitioning, assigning some vfs to the dpdk payload and some
others to pods using net devices.
Also, changes the num of hugepages to 5 as 4 are needed to the two dpdk pods, one to the regular pod.