cgu: add wait for condition and unit tests #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klaskosk
requested review from
kononovn,
trewest,
achuzhoy and
cdvultur
as code owners
klaskosk
force-pushed
the
cgu-condition
branch
2 times, most recently
from
92063c4
to
6941aa3
Compare
cdvultur
reviewed
Jun 14, 2024
sebrandon1
approved these changes
Jun 14, 2024
kononovn
reviewed
Jun 15, 2024
kononovn
reviewed
Jun 15, 2024
kononovn
requested changes
Jun 15, 2024
pkg/cgu/cgu.go
Outdated
| } | ||
|
|
||
| builder.Definition = builder.Object | ||
|
|
||
| for _, condition := range builder.Object.Status.Conditions { | ||
| if condition.Status == isTrue && condition.Type == isComplete { | ||
| return true, nil | ||
| if (expected.Type != "" && condition.Type != expected.Type) || |
There was a problem hiding this comment.
Do we have any particular reason to implement such complicated if condition? Why do we need to change it ?
There was a problem hiding this comment.
@kononovn The diff is a bit weird here. I'm adding a new more general method WaitForCondition and then reimplementing the WaitUntilComplete function using WaitForCondition so the if statement handles more now. I'll use WaitForCondition directly in eco-gotests as well.
I've updated the PR to split the if statement into separate ones for clarity though.
In TALM and ZTP test cases there are many scenarios where we are waiting for a CGU to be in some condition. WaitForCondition generalizes these cases (and the existing WaitUntilComplete) into a single function. Unit tests have been added for WaitForCondition as well as the existing WaitUntilComplete.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In TALM and ZTP test cases there are many scenarios where we are waiting for a CGU to be in some condition. WaitForCondition generalizes these cases (and the existing WaitUntilComplete) into a single function. Unit tests have been added for WaitForCondition as well as the existing WaitUntilComplete.