Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

secret pkg: WithAnnotations and Get methods added + unit test #484

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

elenagerman
Copy link
Contributor

secret pkg: WithAnnotations and Get methods added + unit test

@elenagerman
Copy link
Contributor Author

@kononovn @trewest @cdvultur @achuzhoy PTAL

pkg/clients/clients.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@kononovn kononovn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 comments to fix

pkg/secret/secret.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@kononovn kononovn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kononovn kononovn merged commit 546d8b6 into openshift-kni:main Jun 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants