Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "METAL-759: Add nfs a backed persistent volume (#1608)" #1616

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Revert "METAL-759: Add nfs a backed persistent volume (#1608)" #1616

merged 1 commit into from
Dec 5, 2023

Conversation

derekhiggins
Copy link
Collaborator

This reverts commit b4b21a3.

It may have broken some dualstack setups (depending on which network was priary)

@derekhiggins
Revert "METAL-759: Add nfs a backed persistent volume (openshift-meta…
837e15f 
…l3#1608)"

This reverts commit b4b21a3.

It may have broken some dualstack setups (depending on which
network was priary)
@tdomnesc
Copy link
Contributor

tdomnesc commented Dec 5, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2023
@derekhiggins
Copy link
Collaborator Author

/retest-required

@stbenjam
Copy link
Member

stbenjam commented Dec 5, 2023 •
edited
Loading

/label approved

Approving to unblock dualstack jobs, which are permafailing in periodics

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 5, 2023

@stbenjam: Can not set label approved: Must be member in one of these teams: [openshift-release-oversight]

In response to this:

/label approved

Approving to unblock dualstack jobs, where are permafailing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stbenjam
Copy link
Member

stbenjam commented Dec 5, 2023

/retest-required
/skip

@dtantsur
Copy link
Member

dtantsur commented Dec 5, 2023

/approve

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit c56c785 into openshift-metal3:master Dec 5, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cybertron cybertron Awaiting requested review from cybertron

@sadasu sadasu Awaiting requested review from sadasu

Assignees

@tdomnesc tdomnesc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@derekhiggins @tdomnesc @stbenjam @dtantsur