Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MGMT-16990: Make the go version installed configurable #1634

Merged
merged 1 commit into from
Mar 1, 2024
Merged

MGMT-16990: Make the go version installed configurable #1634

merged 1 commit into from
Mar 1, 2024

Conversation

CrystalChun
Copy link
Contributor

https://issues.redhat.com/browse/MGMT-16990
Hive has increased the minimum go version required to 1.21 which breaks the assisted-service CI jobs since the go version is pinned to 1.20.

This introduces a configurable GOVERSION variable to allow other versions to be specified and installed.

/cc @adriengentil

@CrystalChun
MGMT-16990: Make the go version installed configurable
0989cd5 
https://issues.redhat.com/browse/MGMT-16990
Hive has increased the minimum go version required to 1.21
which breaks the assisted-service CI jobs since the go
version is pinned to 1.20.

This introduces a configurable `GOVERSION` variable to allow
other versions to be specified and installed.
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 21, 2024

@CrystalChun: GitHub didn't allow me to request PR reviews from the following users: adriengentil.

Note that only openshift-metal3 members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

https://issues.redhat.com/browse/MGMT-16990
Hive has increased the minimum go version required to 1.21 which breaks the assisted-service CI jobs since the go version is pinned to 1.20.

This introduces a configurable GOVERSION variable to allow other versions to be specified and installed.

/cc @adriengentil

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 21, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 21, 2024

Hi @CrystalChun. Thanks for your PR.

I'm waiting for a openshift-metal3 member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

adriengentil
adriengentil reviewed Feb 21, 2024
View reviewed changes
Copy link
Contributor

@adriengentil adriengentil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 21, 2024

@adriengentil: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@CrystalChun
Copy link
Contributor Author

/cc @bfournie

@openshift-ci openshift-ci bot requested a review from bfournie February 21, 2024 16:49
@dtantsur
Copy link
Member

/ok-to-test
/approve

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 21, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2024
@CrystalChun CrystalChun mentioned this pull request Feb 21, 2024
Merged
@CrystalChun
Copy link
Contributor Author

Tests failing on

: [sig-metal] should get working host from infra provider expand_less | 0s
-- | --
{  ofcir: Failed to create ci resource: ipi-ci-op-71cbshr5-82588-1760346696551763968}

Will retest in a few moments

@CrystalChun
Copy link
Contributor Author

/retest-required

1 similar comment
@adriengentil
Copy link
Contributor

/retest-required

@adriengentil
Copy link
Contributor

/test e2e-metal-ipi-ovn-ipv6
looks like flakes

@adriengentil
Copy link
Contributor

/retest-required

@adriengentil
Copy link
Contributor

@bfournie @dtantsur can we get a lgtm? Thanks!

@elfosardo
Copy link
Member

/retest

@elfosardo
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2024
@adriengentil
Copy link
Contributor

/test e2e-agent-compact-ipv4

4 similar comments
@adriengentil
Copy link
Contributor

/test e2e-agent-compact-ipv4

@adriengentil
Copy link
Contributor

/test e2e-agent-compact-ipv4

@adriengentil
Copy link
Contributor

/test e2e-agent-compact-ipv4

@adriengentil
Copy link
Contributor

/test e2e-agent-compact-ipv4

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 29, 2024 •
edited
Loading

@CrystalChun: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-ovn-dualstack 0989cd5 link false /test e2e-metal-ipi-ovn-dualstack
ci/prow/e2e-metal-ipi-virtualmedia 0989cd5 link false /test e2e-metal-ipi-virtualmedia
ci/prow/e2e-metal-ipi-serial-ovn-ipv6 0989cd5 link false /test e2e-metal-ipi-serial-ovn-ipv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@CrystalChun
Copy link
Contributor Author

/retest-required

@openshift-merge-bot openshift-merge-bot bot merged commit 85338bf into openshift-metal3:master Mar 1, 2024
9 of 12 checks passed
@zaneb zaneb mentioned this pull request Mar 5, 2024
Closed
@psathyan
Copy link
Contributor

psathyan commented Mar 5, 2024

If go is already installed then GOVERSION=go1.20 is set as part of the environment variables. This would lead to failures as we are trying to reuse the same variable.

2024-03-05 08:07:34 ++(common.sh:8): eval 'GO111MODULE=""
2024-03-05 08:07:34 GOARCH="amd64"
2024-03-05 08:07:34 GOBIN=""
2024-03-05 08:07:34 GOCACHE="/home/ciuser/.cache/go-build"
2024-03-05 08:07:34 GOENV="/home/ciuser/.config/go/env"
2024-03-05 08:07:34 GOEXE=""
2024-03-05 08:07:34 GOEXPERIMENT=""
2024-03-05 08:07:34 GOFLAGS=""
2024-03-05 08:07:34 GOHOSTARCH="amd64"
2024-03-05 08:07:34 GOHOSTOS="linux"
2024-03-05 08:07:34 GOINSECURE=""
2024-03-05 08:07:34 GOMODCACHE="/home/ciuser/go/pkg/mod"
2024-03-05 08:07:34 GONOPROXY=""
2024-03-05 08:07:34 GONOSUMDB=""
2024-03-05 08:07:34 GOOS="linux"
2024-03-05 08:07:34 GOPATH="/home/ciuser/go"
2024-03-05 08:07:34 GOPRIVATE=""
2024-03-05 08:07:34 GOPROXY="https://proxy.golang.org,direct"
2024-03-05 08:07:34 GOROOT="/usr/local/go"
2024-03-05 08:07:34 GOSUMDB="sum.golang.org"
2024-03-05 08:07:34 GOTMPDIR=""
2024-03-05 08:07:34 GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
2024-03-05 08:07:34 GOVCS=""
2024-03-05 08:07:34 GOVERSION="go1.20"
2024-03-05 08:07:34 GCCGO="gccgo"
2024-03-05 08:07:34 GOAMD64="v1"
2024-03-05 08:07:34 AR="ar"
2024-03-05 08:07:34 CC="gcc"
2024-03-05 08:07:34 CXX="g++"
2024-03-05 08:07:34 CGO_ENABLED="1"
2024-03-05 08:07:34 GOMOD="/home/ciuser/src/github.com/openshift-metal3/dev-scripts/go.mod"
2024-03-05 08:07:34 GOWORK=""
2024-03-05 08:07:34 CGO_CFLAGS="-O2 -g"
2024-03-05 08:07:34 CGO_CPPFLAGS=""
2024-03-05 08:07:34 CGO_CXXFLAGS="-O2 -g"
2024-03-05 08:07:34 CGO_FFLAGS="-O2 -g"
2024-03-05 08:07:34 CGO_LDFLAGS="-O2 -g"
2024-03-05 08:07:34 PKG_CONFIG="pkg-config"
2024-03-05 08:07:34 GOGCCFLAGS="-fPIC -m64 -pthread -Wl,--no-gc-sections -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build1909654990=/tmp/go-build -gno-record-gcc-switches"'

@psathyan
Copy link
Contributor

psathyan commented Mar 5, 2024

you would hit

        "\u001b[0;31m        }\u001b[0m",                                                                                                                                                                                                                                                                                    
        "\u001b[0;31m    },\u001b[0m",                                                                                                                                                                                                                                                                                       
        "\u001b[0;31m    \"msg\": \"Request failed\",\u001b[0m",                                                                                                                                                   
        "\u001b[0;31m    \"response\": \"HTTP Error 404: Not Found\",\u001b[0m",                                                                                                                                   
        "\u001b[0;31m    \"status_code\": 404,\u001b[0m",                                                                                                                                                          
        "\u001b[0;31m    \"url\": \"https://storage.googleapis.com/golang/gogo1.19.10.linux-amd64.tar.gz\"\u001b[0m",                                                                                              
        "\u001b[0;31m}\u001b[0m",

@psathyan psathyan mentioned this pull request Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriengentil adriengentil adriengentil left review comments

@bfournie bfournie Awaiting requested review from bfournie

Assignees

@elfosardo elfosardo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@CrystalChun @dtantsur @adriengentil @elfosardo @psathyan