Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the go version variable name. #1640

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

psathyan
Copy link
Contributor

@psathyan psathyan commented Mar 5, 2024

In this PR, we change the variable GOVERSION to GO_VERSION to prevent encountering failures due to mismatched value format.

If go is exists and we execute make, then GOVERSION=go<version> is format of the value being set. However, install-package-playbook.yml expects the value to be only the version instead of the prefix go.

Fixes #1639

Signed-off-by: Pragadeeswaran Sathyanarayanan <psathyan@redhat.com>
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 5, 2024
Copy link

openshift-ci bot commented Mar 5, 2024

Hi @psathyan. Thanks for your PR.

I'm waiting for a openshift-metal3 member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@elfosardo
Copy link
Member

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 5, 2024
@elfosardo
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 5, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 5, 2024
@CrystalChun
Copy link
Contributor

/retest-required

@zaneb
Copy link
Member

zaneb commented Mar 5, 2024

/approve

Copy link

openshift-ci bot commented Mar 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zaneb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2024
Copy link

openshift-ci bot commented Mar 5, 2024

@psathyan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-bm-bond 7c7c819 link false /test e2e-metal-ipi-bm-bond
ci/prow/e2e-metal-ipi-virtualmedia 7c7c819 link false /test e2e-metal-ipi-virtualmedia
ci/prow/e2e-metal-ipi-serial-ovn-ipv6 7c7c819 link false /test e2e-metal-ipi-serial-ovn-ipv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@psathyan
Copy link
Contributor Author

psathyan commented Mar 6, 2024

/retest-required

@openshift-merge-bot openshift-merge-bot bot merged commit a1a8293 into openshift-metal3:master Mar 6, 2024
9 of 12 checks passed
@psathyan psathyan deleted the fixGo branch March 6, 2024 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

01_requirements.sh errors when go is pre-installed.
4 participants