Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Another attempt to update Ansible and metal3-dev-env #1666

Merged
merged 2 commits into from
Jun 24, 2024
Merged

Another attempt to update Ansible and metal3-dev-env #1666

merged 2 commits into from
Jun 24, 2024

Conversation

dtantsur
Copy link
Member

@dtantsur dtantsur commented Jun 17, 2024 •
edited
Loading

The previous one got reverted because it did not account for certain variable changes.

@elfosardo
Copy link
Member

do we want to add the migration to ansible 7 here or open a new PR?
Looking at the logs this passed with the offending change, so it looks good

@dtantsur
Reapply "Upgrade to Ansible 7 (openshift-metal3#1523)" (openshift-met…
7d12b68 
…al3#1665)

This reverts commit 258ee33.
@dtantsur
Pass the right interface name to metal3-dev-env firewall config
bf484d2 
The variable got changed upstream but we're still passing the old one.

Remove no longer valid firewalld commands using even older interface
names.
@dtantsur dtantsur changed the title Pass the right interface name to metal3-dev-env firewall config Another attempt to update Ansible and metal3-dev-env Jun 18, 2024
@derekhiggins
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 18, 2024
@honza
Copy link
Member

honza commented Jun 18, 2024

Do we want a newer version of metal3-dev-env? It currently points to a version from April 2023.

@dtantsur
Copy link
Member Author

Do we want a newer version of metal3-dev-env? It currently points to a version from April 2023.

One step at a time, okay? :) We already have an idea what breaks with this version, the next one will probably need more investigation.

@derekhiggins
Copy link
Collaborator

/test e2e-metal-ipi-serial-ipv4

@elfosardo
Copy link
Member

/retest
failure does not look related

@elfosardo
Copy link
Member

/retest
timeout in ipv4

@derekhiggins
Copy link
Collaborator

/approve

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekhiggins

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 20, 2024
@elfosardo
Copy link
Member

/hold
let's wait for the weekend :)

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 21, 2024
@elfosardo
Copy link
Member

/retest

@elfosardo
Copy link
Member

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 24, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 94fc4df into openshift-metal3:master Jun 24, 2024
12 checks passed
@dtantsur dtantsur deleted the new-metal3-dev-env branch June 24, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cybertron cybertron Awaiting requested review from cybertron

@elfosardo elfosardo Awaiting requested review from elfosardo

Assignees

@derekhiggins derekhiggins

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dtantsur @elfosardo @derekhiggins @honza