Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flag passing when config file isn't present #96

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Fix flag passing when config file isn't present #96

merged 1 commit into from
Sep 22, 2023

Conversation

khrm
Copy link
Member

@khrm khrm commented Sep 22, 2023

Don't return if the file is missing. CMD continues with the flag processing.

Ran:

go get -u  github.com/tektoncd/results/tools/tkn-results@release-v0.8.x
go mod tidy
go mod vendor

@khrm
Fix flag passing when config file isn't present
772a073 
Don't return if the file is missing. CMD continues with the flag processing.
khrm
khrm commented Sep 22, 2023
View reviewed changes
Copy link
Member Author

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign @piyush-garg @concaf

@khrm khrm merged commit 46ed2d9 into openshift-pipelines:release-v1.12.x Sep 22, 2023
3 checks passed
This was referenced Oct 20, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pratap0007 pratap0007 Awaiting requested review from pratap0007

@vdemeester vdemeester Awaiting requested review from vdemeester

Assignees

@concaf concaf

@piyush-garg piyush-garg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@khrm @concaf @piyush-garg