Misc fix #936
Merged
Misc fix #936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Roming22
commented
Feb 8, 2024
Roming22
commented
- Do not run test.sh in debug mode by default.
- Run test.sh in debug mode in the CI
- Auto-formatting of modified shell scripts (you can turn off whitespace diff in the files view to make the review easier)
- Fix an issue that would make any change to the tekton-chains-signing-secret require a manual action for the change to be deployed. It is possible that to deploy this fix, the manual action of deleting the existing job might be required one last time.
gabemontero
reviewed
Feb 8, 2024
operator/gitops/argocd/pipeline-service/openshift-pipelines/chains-secrets-config.yaml
Outdated
Show resolved
Hide resolved
rh-pre-commit.version: 2.1.0 rh-pre-commit.check-secrets: ENABLED
gabemontero
reviewed
Feb 8, 2024
| @@ -4,7 +4,6 @@ | |||
| set -o errexit | |||
| set -o nounset | |||
| set -o pipefail | |||
| set -x | |||
There was a problem hiding this comment.
OK so I see where you turned off debug by default, but I don't see where the --debug arg is getting processed ... is that a default bash thing I'm missing ?
There was a problem hiding this comment.
This done in the parse_args function, around line 48/49.
There was a problem hiding this comment.
ah cool leveraging an existing arg whose impl was too far from the deltas of this PR for me to see ... thanks for the ptr
|
/test test-pipeline-service-upgrade-ocp-414 |
|
/test test-pipeline-service-deployment-ocp-414 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.