Make custom console respect custom params #1250
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| package customparams | ||
|
There was a problem hiding this comment. Can we add test for cel as well ? |
||
|
|
||
| import ( | ||
| "encoding/json" | ||
| "fmt" | ||
|
|
||
| "github.com/google/cel-go/cel" | ||
| "github.com/google/cel-go/checker/decls" | ||
| "github.com/google/cel-go/common/types" | ||
| "github.com/google/cel-go/common/types/ref" | ||
| ) | ||
|
|
||
| func celEvaluate(expr string, env *cel.Env, data map[string]interface{}) (ref.Val, error) { | ||
| parsed, issues := env.Parse(expr) | ||
| if issues != nil && issues.Err() != nil { | ||
| return nil, fmt.Errorf("failed to parse expression %#v: %w", expr, issues.Err()) | ||
| } | ||
|
|
||
| checked, issues := env.Check(parsed) | ||
| if issues != nil && issues.Err() != nil { | ||
| return nil, fmt.Errorf("expression %#v check failed: %w", expr, issues.Err()) | ||
| } | ||
|
|
||
| prg, err := env.Program(checked, cel.EvalOptions(cel.OptOptimize)) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("expression %#v failed to create a Program: %w", expr, err) | ||
| } | ||
|
|
||
| out, _, err := prg.Eval(data) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("expression %#v failed to evaluate: %w", expr, err) | ||
| } | ||
|
|
||
| return out, nil | ||
| } | ||
|
|
||
| // celFilter filters a query with cel, it sets two variables for the user to use | ||
| // in the cel filter. body and pac. | ||
| // body is the payload of the event, since it's already casted we un-marshall/and | ||
| // marshall it as a map[string]interface{} | ||
| func celFilter(query string, body any, pacParams map[string]string) (bool, error) { | ||
| nbody, err := json.Marshal(body) | ||
| if err != nil { | ||
| return false, err | ||
| } | ||
| var jsonMap map[string]interface{} | ||
| err = json.Unmarshal(nbody, &jsonMap) | ||
| if err != nil { | ||
| return false, err | ||
| } | ||
|
|
||
| mapStrDyn := decls.NewMapType(decls.String, decls.Dyn) | ||
| celDec, _ := cel.NewEnv( | ||
| cel.Declarations( | ||
| decls.NewVar("body", mapStrDyn), | ||
| decls.NewVar("pac", mapStrDyn), | ||
| )) | ||
| val, err := celEvaluate(query, celDec, map[string]any{ | ||
| "body": jsonMap, | ||
| "pac": pacParams, | ||
| }) | ||
| if err != nil { | ||
| return false, err | ||
| } | ||
|
|
||
| //nolint: gocritic | ||
| switch val.(type) { | ||
| case types.Bool: | ||
| if val.Value() == true { | ||
| return true, nil | ||
| } | ||
| } | ||
| return false, nil | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove "a"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also remove "for"