-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added support for azure devops #1654
base: main
Are you sure you want to change the base?
added support for azure devops #1654
Conversation
aayeshaarshad
commented
Apr 8, 2024
•
edited
Loading
edited
- Added support to detect X-Azure-DevOps-EventType in request header
- Parse payload for push and pull event
- Created connection with client using pat
- Get the files inside .tekton directory
- Ran a successful pipelinerun
- Set the status; currently tested pending/failed/successful on push
- Write implementation of missing methods (acl.go, CreateToken, GetFileInsideRepo)
- Write test cases
- Do complete e2e testing on both pull and push
/ok-to-test |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1654 +/- ##
==========================================
- Coverage 64.31% 62.97% -1.34%
==========================================
Files 140 144 +4
Lines 10789 11326 +537
==========================================
+ Hits 6939 7133 +194
- Misses 3334 3661 +327
- Partials 516 532 +16 ☔ View full report in Codecov by Sentry. |
- Added new unit tests for Azure DevOps support. - Improved test coverage for parse payload functions.
382ff4f
to
abcc3dc
Compare
/test go-testing |
@chmouel any update on review? |
@chmouel we will appreciate if you can please review it; as we would like this be merged into main branch! can you confirm when you can review it? we have two OpenShift customers and who really wants to use this and they want it to be part of the main release |
@chmouel an reminder; any updates on this? |
@chmouel any updates on this? we are really surprised how poor the response time is! I will appreciate if we can hear back |
@chmouel any updates on this PR? It’s quite frustrating that we've been trying to follow up without receiving any response. We would appreciate it if you could let us know your plans for this PR. |
@chmouel any updates on this? We would like it to be merged |