Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for azure devops #1654

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

aayeshaarshad
Copy link

@aayeshaarshad aayeshaarshad commented Apr 8, 2024

  • Added support to detect X-Azure-DevOps-EventType in request header
  • Parse payload for push and pull event
  • Created connection with client using pat
  • Get the files inside .tekton directory
  • Ran a successful pipelinerun
  • Set the status; currently tested pending/failed/successful on push
  • Write implementation of missing methods (acl.go, CreateToken, GetFileInsideRepo)
  • Write test cases
  • Do complete e2e testing on both pull and push

@aayeshaarshad aayeshaarshad changed the title added support for azure devops [WIP] added support for azure devops Apr 8, 2024
@chmouel
Copy link
Member

chmouel commented Apr 11, 2024

/ok-to-test

Copy link

codecov bot commented Apr 11, 2024

Codecov Report

Attention: Patch coverage is 36.24535% with 343 lines in your changes are missing coverage. Please review.

Project coverage is 62.97%. Comparing base (5ecb9ea) to head (a1af7e8).
Report is 53 commits behind head on main.

❗ Current head a1af7e8 differs from pull request most recent head fd7c2c3. Consider uploading reports for the commit fd7c2c3 to get more accurate results

Files Patch % Lines
pkg/provider/azuredevops/azuredevops.go 21.91% 279 Missing and 6 partials ⚠️
pkg/provider/azuredevops/acl.go 0.00% 19 Missing ⚠️
pkg/provider/azuredevops/parse_payload.go 85.14% 10 Missing and 5 partials ⚠️
pkg/reconciler/event.go 0.00% 11 Missing and 1 partial ⚠️
pkg/kubeinteraction/labels.go 25.00% 4 Missing and 2 partials ⚠️
pkg/adapter/adapter.go 40.00% 2 Missing and 1 partial ⚠️
pkg/provider/azuredevops/detect.go 88.88% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1654      +/-   ##
==========================================
- Coverage   64.31%   62.97%   -1.34%     
==========================================
  Files         140      144       +4     
  Lines       10789    11326     +537     
==========================================
+ Hits         6939     7133     +194     
- Misses       3334     3661     +327     
- Partials      516      532      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- Added new unit tests for Azure DevOps support.
- Improved test coverage for parse payload functions.
- Removed all go-lint issues
@chmouel
Copy link
Member

chmouel commented Apr 16, 2024

/test go-testing

@aayeshaarshad aayeshaarshad changed the title [WIP] added support for azure devops added support for azure devops Apr 16, 2024
- documentation
- e2e testing
- acl implementation
- updated GitClient
- update parse
- code cleanup
@aayeshaarshad
Copy link
Author

@chmouel any update on review?

@rasheedamir
Copy link

rasheedamir commented Jun 4, 2024

@chmouel we will appreciate if you can please review it; as we would like this be merged into main branch! can you confirm when you can review it?

we have two OpenShift customers and who really wants to use this and they want it to be part of the main release

@rasheedamir
Copy link

@chmouel an reminder; any updates on this?

@rasheedamir
Copy link

@chmouel any updates on this? we are really surprised how poor the response time is! I will appreciate if we can hear back

@rasheedamir
Copy link

@chmouel any updates on this PR? It’s quite frustrating that we've been trying to follow up without receiving any response. We would appreciate it if you could let us know your plans for this PR.

@rasheedamir
Copy link

@chmouel any updates on this? We would like it to be merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants