Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE, CI ONLY: Downstream 0.8.0 04 #57

Conversation

ramessesii2
Copy link
Member

New features

Add owner references check optional in watcher

Changes that require changes to our deployment configuration

NA

Breaking changes:

NA

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Tested your changes locally (if this is a code change)
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user-facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contain the string "action required" if the change requires additional action from users switching to the new release

Release Notes

sayan-biswas and others added 2 commits November 28, 2023 07:32
This feature makes the owner reference check in watcher optional.
We keep the downstream changes as a single commit included on the top of
each downstream branch. Subsequent downstream changes will be squashed
into this one.
Copy link
Member

@avinal avinal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@enarha
Copy link

enarha commented Nov 30, 2023

/lgtm

@ramessesii2
Copy link
Member Author

Closing this one, and pushing new branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants