CORS-3582: remove unused installer feature gates

The CAPI features gates are not needed anymore for platforms where CAPI provisioning is the default. Also CAPI/aws replaced the AWS SDK provisioner, so the AlternateInfrastructureAWS feature gate is not needed anymore.
openshift · Aug 26, 2024 · b667a6f · b667a6f
1 parent 2b42490
commit b667a6f
Show file tree

Hide file tree

Showing 8 changed files with 0 additions and 208 deletions.
diff --git a/features.md b/features.md
@@ -22,7 +22,6 @@
 | InsightsConfig| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span>  |
 | InsightsConfigAPI| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span>  |
 | InsightsOnDemandDataGather| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span>  |
-| InstallAlternateInfrastructureAWS| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span>  |
 | MachineAPIProviderOpenStack| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span>  |
 | MachineConfigNodes| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span>  |
 | ManagedBootImagesAWS| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span>  |
@@ -57,13 +56,6 @@
 | BuildCSIVolumes| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span>  |
 | ChunkSizeMiB| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span>  |
 | CloudDualStackNodeIPs| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span>  |
-| ClusterAPIInstallAWS| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span>  |
-| ClusterAPIInstallAzure| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span>  |
-| ClusterAPIInstallGCP| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span>  |
-| ClusterAPIInstallNutanix| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span>  |
-| ClusterAPIInstallOpenStack| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span>  |
-| ClusterAPIInstallPowerVS| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span>  |
-| ClusterAPIInstallVSphere| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span>  |
 | DisableKubeletCloudCredentialProviders| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span>  |
 | GCPLabelsTags| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span>  |
 | HardwareSpeed| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span>  |

diff --git a/features/features.go b/features/features.go
@@ -299,13 +299,6 @@ var (
 					enableIn(configv1.Default, configv1.DevPreviewNoUpgrade, configv1.TechPreviewNoUpgrade).
 					mustRegister()
 
-	FeatureGateInstallAlternateInfrastructureAWS = newFeatureGate("InstallAlternateInfrastructureAWS").
-							reportProblemsToJiraComponent("Installer").
-							contactPerson("padillon").
-							productScope(ocpSpecific).
-							enableIn(configv1.DevPreviewNoUpgrade, configv1.TechPreviewNoUpgrade).
-							mustRegister()
-
 	FeatureGateGCPClusterHostedDNS = newFeatureGate("GCPClusterHostedDNS").
 					reportProblemsToJiraComponent("Installer").
 					contactPerson("barbacbd").
@@ -468,61 +461,12 @@ var (
 						enableIn(configv1.Default, configv1.DevPreviewNoUpgrade, configv1.TechPreviewNoUpgrade).
 						mustRegister()
 
-	FeatureGateClusterAPIInstallAWS = newFeatureGate("ClusterAPIInstallAWS").
-					reportProblemsToJiraComponent("Installer").
-					contactPerson("r4f4").
-					productScope(ocpSpecific).
-					enableIn(configv1.Default, configv1.DevPreviewNoUpgrade, configv1.TechPreviewNoUpgrade).
-					mustRegister()
-
-	FeatureGateClusterAPIInstallAzure = newFeatureGate("ClusterAPIInstallAzure").
-						reportProblemsToJiraComponent("Installer").
-						contactPerson("jhixson74").
-						productScope(ocpSpecific).
-						enableIn(configv1.Default, configv1.DevPreviewNoUpgrade, configv1.TechPreviewNoUpgrade).
-						mustRegister()
-
-	FeatureGateClusterAPIInstallGCP = newFeatureGate("ClusterAPIInstallGCP").
-					reportProblemsToJiraComponent("Installer").
-					contactPerson("bfournie").
-					productScope(ocpSpecific).
-					enableIn(configv1.Default, configv1.DevPreviewNoUpgrade, configv1.TechPreviewNoUpgrade).
-					mustRegister()
-
 	FeatureGateClusterAPIInstallIBMCloud = newFeatureGate("ClusterAPIInstallIBMCloud").
 						reportProblemsToJiraComponent("Installer").
 						contactPerson("cjschaef").
 						productScope(ocpSpecific).
 						mustRegister()
 
-	FeatureGateClusterAPIInstallNutanix = newFeatureGate("ClusterAPIInstallNutanix").
-						reportProblemsToJiraComponent("Installer").
-						contactPerson("yanhua121").
-						productScope(ocpSpecific).
-						enableIn(configv1.Default, configv1.DevPreviewNoUpgrade, configv1.TechPreviewNoUpgrade).
-						mustRegister()
-
-	FeatureGateClusterAPIInstallOpenStack = newFeatureGate("ClusterAPIInstallOpenStack").
-						reportProblemsToJiraComponent("Installer").
-						contactPerson("stephenfin").
-						productScope(ocpSpecific).
-						enableIn(configv1.Default, configv1.DevPreviewNoUpgrade, configv1.TechPreviewNoUpgrade).
-						mustRegister()
-
-	FeatureGateClusterAPIInstallPowerVS = newFeatureGate("ClusterAPIInstallPowerVS").
-						reportProblemsToJiraComponent("Installer").
-						contactPerson("mjturek").
-						productScope(ocpSpecific).
-						enableIn(configv1.Default, configv1.DevPreviewNoUpgrade, configv1.TechPreviewNoUpgrade).
-						mustRegister()
-
-	FeatureGateClusterAPIInstallVSphere = newFeatureGate("ClusterAPIInstallVSphere").
-						reportProblemsToJiraComponent("Installer").
-						contactPerson("rvanderp3").
-						productScope(ocpSpecific).
-						enableIn(configv1.Default, configv1.DevPreviewNoUpgrade, configv1.TechPreviewNoUpgrade).
-						mustRegister()
-
 	FeatureGateChunkSizeMiB = newFeatureGate("ChunkSizeMiB").
 				reportProblemsToJiraComponent("Image Registry").
 				contactPerson("flavianmissi").

diff --git a/payload-manifests/featuregates/featureGate-Hypershift-Default.yaml b/payload-manifests/featuregates/featureGate-Hypershift-Default.yaml
@@ -70,9 +70,6 @@
                     {
                         "name": "InsightsOnDemandDataGather"
                     },
-                    {
-                        "name": "InstallAlternateInfrastructureAWS"
-                    },
                     {
                         "name": "MachineAPIMigration"
                     },
@@ -183,27 +180,6 @@
                     {
                         "name": "CloudDualStackNodeIPs"
                     },
-                    {
-                        "name": "ClusterAPIInstallAWS"
-                    },
-                    {
-                        "name": "ClusterAPIInstallAzure"
-                    },
-                    {
-                        "name": "ClusterAPIInstallGCP"
-                    },
-                    {
-                        "name": "ClusterAPIInstallNutanix"
-                    },
-                    {
-                        "name": "ClusterAPIInstallOpenStack"
-                    },
-                    {
-                        "name": "ClusterAPIInstallPowerVS"
-                    },
-                    {
-                        "name": "ClusterAPIInstallVSphere"
-                    },
                     {
                         "name": "DisableKubeletCloudCredentialProviders"
                     },

diff --git a/payload-manifests/featuregates/featureGate-Hypershift-DevPreviewNoUpgrade.yaml b/payload-manifests/featuregates/featureGate-Hypershift-DevPreviewNoUpgrade.yaml
@@ -71,27 +71,6 @@
                     {
                         "name": "CloudDualStackNodeIPs"
                     },
-                    {
-                        "name": "ClusterAPIInstallAWS"
-                    },
-                    {
-                        "name": "ClusterAPIInstallAzure"
-                    },
-                    {
-                        "name": "ClusterAPIInstallGCP"
-                    },
-                    {
-                        "name": "ClusterAPIInstallNutanix"
-                    },
-                    {
-                        "name": "ClusterAPIInstallOpenStack"
-                    },
-                    {
-                        "name": "ClusterAPIInstallPowerVS"
-                    },
-                    {
-                        "name": "ClusterAPIInstallVSphere"
-                    },
                     {
                         "name": "ClusterMonitoringConfig"
                     },
@@ -140,9 +119,6 @@
                     {
                         "name": "InsightsOnDemandDataGather"
                     },
-                    {
-                        "name": "InstallAlternateInfrastructureAWS"
-                    },
                     {
                         "name": "KMSv1"
                     },

diff --git a/payload-manifests/featuregates/featureGate-Hypershift-TechPreviewNoUpgrade.yaml b/payload-manifests/featuregates/featureGate-Hypershift-TechPreviewNoUpgrade.yaml
@@ -74,27 +74,6 @@
                     {
                         "name": "CloudDualStackNodeIPs"
                     },
-                    {
-                        "name": "ClusterAPIInstallAWS"
-                    },
-                    {
-                        "name": "ClusterAPIInstallAzure"
-                    },
-                    {
-                        "name": "ClusterAPIInstallGCP"
-                    },
-                    {
-                        "name": "ClusterAPIInstallNutanix"
-                    },
-                    {
-                        "name": "ClusterAPIInstallOpenStack"
-                    },
-                    {
-                        "name": "ClusterAPIInstallPowerVS"
-                    },
-                    {
-                        "name": "ClusterAPIInstallVSphere"
-                    },
                     {
                         "name": "ClusterMonitoringConfig"
                     },
@@ -140,9 +119,6 @@
                     {
                         "name": "InsightsOnDemandDataGather"
                     },
-                    {
-                        "name": "InstallAlternateInfrastructureAWS"
-                    },
                     {
                         "name": "KMSv1"
                     },

diff --git a/payload-manifests/featuregates/featureGate-SelfManagedHA-Default.yaml b/payload-manifests/featuregates/featureGate-SelfManagedHA-Default.yaml
@@ -73,9 +73,6 @@
                     {
                         "name": "InsightsOnDemandDataGather"
                     },
-                    {
-                        "name": "InstallAlternateInfrastructureAWS"
-                    },
                     {
                         "name": "MachineAPIMigration"
                     },
@@ -186,27 +183,6 @@
                     {
                         "name": "CloudDualStackNodeIPs"
                     },
-                    {
-                        "name": "ClusterAPIInstallAWS"
-                    },
-                    {
-                        "name": "ClusterAPIInstallAzure"
-                    },
-                    {
-                        "name": "ClusterAPIInstallGCP"
-                    },
-                    {
-                        "name": "ClusterAPIInstallNutanix"
-                    },
-                    {
-                        "name": "ClusterAPIInstallOpenStack"
-                    },
-                    {
-                        "name": "ClusterAPIInstallPowerVS"
-                    },
-                    {
-                        "name": "ClusterAPIInstallVSphere"
-                    },
                     {
                         "name": "DisableKubeletCloudCredentialProviders"
                     },

diff --git a/payload-manifests/featuregates/featureGate-SelfManagedHA-DevPreviewNoUpgrade.yaml b/payload-manifests/featuregates/featureGate-SelfManagedHA-DevPreviewNoUpgrade.yaml
@@ -71,27 +71,6 @@
                     {
                         "name": "CloudDualStackNodeIPs"
                     },
-                    {
-                        "name": "ClusterAPIInstallAWS"
-                    },
-                    {
-                        "name": "ClusterAPIInstallAzure"
-                    },
-                    {
-                        "name": "ClusterAPIInstallGCP"
-                    },
-                    {
-                        "name": "ClusterAPIInstallNutanix"
-                    },
-                    {
-                        "name": "ClusterAPIInstallOpenStack"
-                    },
-                    {
-                        "name": "ClusterAPIInstallPowerVS"
-                    },
-                    {
-                        "name": "ClusterAPIInstallVSphere"
-                    },
                     {
                         "name": "ClusterMonitoringConfig"
                     },
@@ -140,9 +119,6 @@
                     {
                         "name": "InsightsOnDemandDataGather"
                     },
-                    {
-                        "name": "InstallAlternateInfrastructureAWS"
-                    },
                     {
                         "name": "KMSv1"
                     },

diff --git a/payload-manifests/featuregates/featureGate-SelfManagedHA-TechPreviewNoUpgrade.yaml b/payload-manifests/featuregates/featureGate-SelfManagedHA-TechPreviewNoUpgrade.yaml
@@ -74,27 +74,6 @@
                     {
                         "name": "CloudDualStackNodeIPs"
                     },
-                    {
-                        "name": "ClusterAPIInstallAWS"
-                    },
-                    {
-                        "name": "ClusterAPIInstallAzure"
-                    },
-                    {
-                        "name": "ClusterAPIInstallGCP"
-                    },
-                    {
-                        "name": "ClusterAPIInstallNutanix"
-                    },
-                    {
-                        "name": "ClusterAPIInstallOpenStack"
-                    },
-                    {
-                        "name": "ClusterAPIInstallPowerVS"
-                    },
-                    {
-                        "name": "ClusterAPIInstallVSphere"
-                    },
                     {
                         "name": "ClusterMonitoringConfig"
                     },
@@ -140,9 +119,6 @@
                     {
                         "name": "InsightsOnDemandDataGather"
                     },
-                    {
-                        "name": "InstallAlternateInfrastructureAWS"
-                    },
                     {
                         "name": "KMSv1"
                     },