Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-33146: [release-4.14] OCPBUGS-16483: Update apimachinery dependency to remove goproxy dep #709

Merged

Conversation

rwsu
Copy link
Contributor

@rwsu rwsu commented Apr 30, 2024

This is a manual cherrypick of PR#590

A denial of service (DoS) via unspecified vectors issue was found in goproxy (CVE-2023-37788). goproxy is not used directly by the agent. It is pulled in by apimachinery. apimachinery ceases to use goproxy after v0.27.0.

To prevent the potential issue, apimachiney is updated to v0.27.2.

A denial of service (DoS) via unspecified vectors issue was found
in goproxy (CVE-2023-37788). goproxy is not used directly by the
agent. It is pulled in by apimachinery. apimachinery ceases to use
goproxy after v0.27.0.

To prevent the potential issue, apimachiney is updated to v0.27.2.
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 30, 2024
@openshift-ci-robot
Copy link

@rwsu: This pull request references Jira Issue OCPBUGS-16483, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
  • expected Jira Issue OCPBUGS-16483 to depend on a bug targeting a version in 4.15.0, 4.15.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is a manual cherrypick of PR#590

A denial of service (DoS) via unspecified vectors issue was found in goproxy (CVE-2023-37788). goproxy is not used directly by the agent. It is pulled in by apimachinery. apimachinery ceases to use goproxy after v0.27.0.

To prevent the potential issue, apimachiney is updated to v0.27.2.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 30, 2024
@rwsu
Copy link
Contributor Author

rwsu commented Apr 30, 2024

/jira cherrypick OCPBUGS-16483

@openshift-ci-robot
Copy link

@rwsu: Jira Issue OCPBUGS-16483 has been cloned as Jira Issue OCPBUGS-33146. Will retitle bug to link to clone.
/retitle OCPBUGS-33146: [release-4.14] OCPBUGS-16483: Update apimachinery dependency to remove goproxy dep

In response to this:

/jira cherrypick OCPBUGS-16483

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.14] OCPBUGS-16483: Update apimachinery dependency to remove goproxy dep OCPBUGS-33146: [release-4.14] OCPBUGS-16483: Update apimachinery dependency to remove goproxy dep Apr 30, 2024
@openshift-ci-robot
Copy link

@rwsu: This pull request references Jira Issue OCPBUGS-33146, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
  • expected dependent Jira Issue OCPBUGS-16483 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ASSIGNED instead
  • expected dependent Jira Issue OCPBUGS-16483 to target a version in 4.15.0, 4.15.z, but it targets "4.14.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is a manual cherrypick of PR#590

A denial of service (DoS) via unspecified vectors issue was found in goproxy (CVE-2023-37788). goproxy is not used directly by the agent. It is pulled in by apimachinery. apimachinery ceases to use goproxy after v0.27.0.

To prevent the potential issue, apimachiney is updated to v0.27.2.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 30, 2024
@rwsu
Copy link
Contributor Author

rwsu commented Aug 21, 2024

/remove-lifecycle stale

@openshift-ci openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 21, 2024
@rwsu
Copy link
Contributor Author

rwsu commented Aug 21, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 21, 2024
@openshift-ci-robot
Copy link

@rwsu: This pull request references Jira Issue OCPBUGS-33146, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.z) matches configured target version for branch (4.14.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-16483 is in the state Closed (Done-Errata), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-16483 targets the "4.15.z" version, which is one of the valid target versions: 4.15.0, 4.15.z
  • bug has dependents

Requesting review from QA contact:
/cc @mhanss

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from mhanss August 21, 2024 21:38
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2024
Copy link

openshift-ci bot commented Sep 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gamli75, rwsu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2024
Copy link

openshift-ci bot commented Sep 11, 2024

@rwsu: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 4106eb4 into openshift:release-4.14 Sep 11, 2024
3 checks passed
@openshift-ci-robot
Copy link

@rwsu: Jira Issue OCPBUGS-33146: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-33146 has been moved to the MODIFIED state.

In response to this:

This is a manual cherrypick of PR#590

A denial of service (DoS) via unspecified vectors issue was found in goproxy (CVE-2023-37788). goproxy is not used directly by the agent. It is pulled in by apimachinery. apimachinery ceases to use goproxy after v0.27.0.

To prevent the potential issue, apimachiney is updated to v0.27.2.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-agent-installer-node-agent
This PR has been included in build ose-agent-installer-node-agent-container-v4.14.0-202409112037.p0.g4106eb4.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants