OCPBUGS-33404: Make removable disks eligible

[adriengentil]

Depending on machine configuration internal disks may appears as
removable.

Let's drop this check to un-block installations in such setup.

[openshift-ci-robot]

@adriengentil: This pull request references Jira Issue OCPBUGS-33404, which is invalid:

• expected the bug to target the "4.17.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Depending on machine configuration internal disks may appears as
removable.

Let's drop this check to un-block installations in such setup.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[adriengentil]

/jira refresh

[openshift-ci-robot]

@adriengentil: This pull request references Jira Issue OCPBUGS-33404, which is invalid:

• expected the bug to target the "4.17.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[avishayt]

/lgtm

[adriengentil]

/jira refresh

[openshift-ci-robot]

@adriengentil: This pull request references Jira Issue OCPBUGS-33404, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.17.0) matches configured target version for branch (4.17.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @mhanss

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[adriengentil]

/cherry-pick release-4.16 release-4.15

[openshift-cherrypick-robot]

@adriengentil: once the present PR merges, I will cherry-pick it on top of release-4.16 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.16 release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriengentil, avishayt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [adriengentil,avishayt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[adriengentil]

/cc @gamli75

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.89%. Comparing base (ab42a45) to head (325897e).

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #716      +/-   ##
==========================================
- Coverage   59.91%   59.89%   -0.03%     
==========================================
  Files          74       74              
  Lines        3705     3703       -2     
==========================================
- Hits         2220     2218       -2     
  Misses       1328     1328              
  Partials      157      157              

Files	Coverage Δ
src/inventory/disks.go	90.29% <ø> (-0.07%)	⬇️

[openshift-ci]

@adriengentil: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@adriengentil: Jira Issue OCPBUGS-33404: All pull requests linked via external trackers have merged:

• openshift/assisted-installer-agent#716

Jira Issue OCPBUGS-33404 has been moved to the MODIFIED state.

In response to this:

Depending on machine configuration internal disks may appears as
removable.

Let's drop this check to un-block installations in such setup.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-cherrypick-robot]

@adriengentil: new pull request created: #717

In response to this:

/cherry-pick release-4.16 release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.