Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-ocm-2.11] MGMT-18332: Use centos stream 9 as the base image for test container #749

Conversation

danmanor
Copy link
Contributor

@danmanor danmanor commented Jul 7, 2024

  • Use centos stream 9 as the base image for test container
  • Replace deprecated scopelint linter

@openshift-ci-robot
Copy link

@danmanor: This pull request explicitly references no jira issue.

In response to this:

  • Use centos stream 9 as the base image for test container
  • Replace deprecated scopelint linter

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 7, 2024
@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 7, 2024
@openshift-ci openshift-ci bot requested review from gamli75 and rccrdpccl July 7, 2024 14:01
Copy link

openshift-ci bot commented Jul 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danmanor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2024
Copy link

codecov bot commented Jul 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.86%. Comparing base (dfe67f1) to head (c35d269).

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##           release-ocm-2.11     #749      +/-   ##
====================================================
- Coverage             59.91%   59.86%   -0.06%     
====================================================
  Files                    74       74              
  Lines                  3705     3705              
====================================================
- Hits                   2220     2218       -2     
- Misses                 1328     1329       +1     
- Partials                157      158       +1     

see 1 file with indirect coverage changes

@danmanor
Copy link
Contributor Author

danmanor commented Jul 7, 2024

/override ci/prow/e2e-ai-operator-ztp

Copy link

openshift-ci bot commented Jul 7, 2024

@danmanor: Overrode contexts on behalf of danmanor: ci/prow/e2e-ai-operator-ztp

In response to this:

/override ci/prow/e2e-ai-operator-ztp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@danmanor danmanor changed the title [release-ocm-2.11] NO-ISSUE: Use centos stream 9 as the base image for test container [release-ocm-2.11] MGMT-18336: Use centos stream 9 as the base image for test container Jul 7, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 7, 2024

@danmanor: This pull request references MGMT-18336 which is a valid jira issue.

In response to this:

  • Use centos stream 9 as the base image for test container
  • Replace deprecated scopelint linter

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@danmanor danmanor changed the title [release-ocm-2.11] MGMT-18336: Use centos stream 9 as the base image for test container [release-ocm-2.11] MGMT-18332: Use centos stream 9 as the base image for test container Jul 7, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 7, 2024

@danmanor: This pull request references MGMT-18332 which is a valid jira issue.

In response to this:

  • Use centos stream 9 as the base image for test container
  • Replace deprecated scopelint linter

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

openshift-ci bot commented Jul 7, 2024

@danmanor: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rccrdpccl
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2024
Copy link

openshift-ci bot commented Jul 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danmanor, rccrdpccl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 67e0d93 into openshift:release-ocm-2.11 Jul 8, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants