Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTA-1166: describe manifests #185

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

hongkailiu
Copy link
Member

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 27, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 27, 2024

@hongkailiu: This pull request references OTA-1166 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@hongkailiu
Copy link
Member Author

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 27, 2024
@hongkailiu hongkailiu force-pushed the OTA-1166 branch 9 times, most recently from be7e389 to 41d7cc4 Compare June 28, 2024 20:29
@hongkailiu
Copy link
Member Author

/retest-required

@hongkailiu hongkailiu changed the title [wip]OTA-1166: describe manifests OTA-1166: describe manifests Jun 29, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 29, 2024
config/manager/manager.yaml Outdated Show resolved Hide resolved
controllers/new.go Outdated Show resolved Hide resolved
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 3, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 3, 2024
Copy link
Member

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2024
Copy link
Contributor

openshift-ci bot commented Jul 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongkailiu, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2024
@hongkailiu
Copy link
Member Author

/hold

Testing a bit with cluster bot + PR ...

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2024
@hongkailiu
Copy link
Member Author

/retest-required

1 similar comment
@hongkailiu
Copy link
Member Author

/retest-required

Copy link
Contributor

openshift-ci bot commented Jul 8, 2024

@hongkailiu: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hongkailiu
Copy link
Member Author

Verify with a cluster-bot cluster: The results look reasonable to me.

launch 4.16,openshift/cincinnati-operator#185 aws

and

$ oc --kubeconfig ~/Downloads/cluster-bot-2024-07-08-204156.kubeconfig.txt -n install-osus-here get ClusterServiceVersion update-service-operator.v5.0.2-dev -o yaml | yq -y '.metadata.annotations."kubernetes.io/description"'
"This OpenShift Update Service operator Deployment reconciles local UpdateServices\
  \ into more fundamental Kubernetes\nand OpenShift resources like Cincinnati Deployments\
  \ and Routes, and it reports the status of those components in \nthe UpdateService\
  \ status.\n"

## This should be related to how the deployment is installed on the cluster (it may differs from how OLM handes CSV)
$ oc --kubeconfig ~/Downloads/cluster-bot-2024-07-08-204156.kubeconfig.txt -n install-osus-here get deployment updateservice-operator -o yaml | yq -y '.metadata.annotations."kubernetes.io/description"'
null

$ oc --kubeconfig ~/Downloads/cluster-bot-2024-07-08-204156.kubeconfig.txt -n install-osus-here get pdb sample -o  yaml | yq -y '.metadata.annotations."kubernetes.io/description"'
This PodDisruptionBudget blocks graceful evictions (but cannot guard against all external
  disruption) to try and keep at least one Pod running at all times, if the Update
  Service instance specifies two or more replicas.

$ oc --kubeconfig ~/Downloads/cluster-bot-2024-07-08-204156.kubeconfig.txt -n install-osus-here get svc sample-graph-builder -o  yaml | yq -y '.metadata.annotations."kubernetes.io/description"'
This Service exposes a client-agnostic update graph to other clients within the cluster.
  This allows convenient in-cluster access to those graphs, and also allows platform
  monitoring to scrape graph-builder containers for Prometheus metrics. See https://github.com/openshift/cincinnati/blob/master/docs/design/cincinnati.md#graph-builder
  for more details

$ oc --kubeconfig ~/Downloads/cluster-bot-2024-07-08-204156.kubeconfig.txt -n install-osus-here get svc sample-metadata -o  yaml | yq -y '.metadata.annotations."kubernetes.io/description"'
It exposes release image signatures See https://github.com/openshift/cincinnati-graph-data?tab=readme-ov-file#signatures
  for more details

$ oc --kubeconfig ~/Downloads/cluster-bot-2024-07-08-204156.kubeconfig.txt -n install-osus-here get svc sample-policy-engine -o  yaml | yq -y '.metadata.annotations."kubernetes.io/description"'
It exposes views of the update graph by applying a set of filters which are defined
  within the particular Policy Engine instance. See https://github.com/openshift/cincinnati/blob/master/docs/design/cincinnati.md#policy-engine
  for more details


$ oc --kubeconfig ~/Downloads/cluster-bot-2024-07-08-204156.kubeconfig.txt -n install-osus-here get route sample-route -o  yaml | yq -y '.metadata.annotations."kubernetes.io/description"'
It exposes views of the update graph by applying a set of filters which are defined
  within the particular Policy Engine instance. See https://github.com/openshift/cincinnati/blob/master/docs/design/cincinnati.md#policy-engine
  for more details

$ oc --kubeconfig ~/Downloads/cluster-bot-2024-07-08-204156.kubeconfig.txt -n install-osus-here get route sample-meta-route -o  yaml | yq -y '.metadata.annotations."kubernetes.io/description"'
It exposes release image signatures See https://github.com/openshift/cincinnati-graph-data?tab=readme-ov-file#signatures
  for more details

$ oc --kubeconfig ~/Downloads/cluster-bot-2024-07-08-204156.kubeconfig.txt -n install-osus-here get cm sample-config -o yaml |  yq -y '.metadata.annotations."kubernetes.io/description"'
This ConfigMap contains the configuration file for the graph-builder

$ oc --kubeconfig ~/Downloads/cluster-bot-2024-07-08-204156.kubeconfig.txt -n install-osus-here get cm sample-env -o yaml |  yq -y '.metadata.annotations."kubernetes.io/description"'
This ConfigMap contains the environment information shared by the containers of UpdateService

$ oc --kubeconfig ~/Downloads/cluster-bot-2024-07-08-204156.kubeconfig.txt -n install-osus-here get deployment sample -o yaml | yq -y '.metadata.annotations."kubernetes.io/description"'
This deployment launches the components for the OpenShift UpdateService sample

$ oc --kubeconfig ~/Downloads/cluster-bot-2024-07-08-204156.kubeconfig.txt -n install-osus-here get secret sample-pull-secret -o yaml |  yq -y '.metadata.annotations."kubernetes.io/description"'
It contains the pull credentials from the global pull secret for the cluster

### Maybe it is not created by default
$ oc --kubeconfig ~/Downloads/cluster-bot-2024-07-08-204156.kubeconfig.txt -n install-osus-here get cm | grep trusted-ca

@hongkailiu
Copy link
Member Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 0b1be98 into openshift:master Jul 8, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants