Merge https://github.com/kubernetes/cloud-provider-azure:master into master #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cloud-team-rebase-bot[bot]](https://avatars.githubusercontent.com/u/74064623?s=60&v=4){kind=small}
fix private zone creation issue fix: create private endpoint for every account created by driver revert add unit test auto register
…point-matching fix: PrivateEndpoint matching in storage account search
…etrg fix: respect VnetResourceGroup in private link creation
docs: fix broken links
use PatchResourceAsync for vmas feat: async detach disk fix ut fix ut fix golint fix ut remove retry in Detachdisk fix ut fix ut fix golint return LUN directly if disk is already attached reduce get disk operations fix ut remove future check add logging
…raw-error-twice fix: avoid wrapping RawError twice
fix logs fix ut read QPS from config user lower limit set rate limit config fix ut fix logging
fix golint fix ut
feat: support async attach/detach disk
docker buildx will allow us to build Windows images on a Linux node. Using this approach, we can build any Windows image for any OS Version without having to have the latest Windows node (typically, you cannot build Windows Container Images for OS Versions newer than the host's), and without having to rely on Hyper-V Support (typically, you cannot build Windows Container Images for OS Versions older than the host's without Hyper-V Isolation). The image building approach is similar to the one used to build the Windows pause images and the E2E test images in Kubernetes: - when using docker buildx for Windows images, the output type must be "registry", which means that the image is being built and pushed. - docker buildx does not add any "os.version" information in the images, which is necessary for manifest lists containing Windows images. We have to set it ourselves. - pulling mcr.microsoft.com/windows/servercore:1809 just to get netapi32.dll from it can be a bit inefficient, especially when considering the images is ~2GB. Instead, we can use gcr.io/k8s-staging-e2e-test-images/windows-servercore-cache:1.0-linux-amd64-$OSVERSION as a source for the dll, which is a scratch image containing a few commonly needed DLLs.
fix: ignore the NodeCIDRMaskSize in dualstack clusters
chore: add configuration for dependabot
Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.8.1 to 1.14.0. - [Release notes](https://github.com/onsi/gomega/releases) - [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md) - [Commits](onsi/gomega@v1.8.1...v1.14.0) --- updated-dependencies: - dependency-name: github.com/onsi/gomega dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…t/go_modules/github.com/onsi/gomega-1.14.0 chore(deps): bump github.com/onsi/gomega from 1.8.1 to 1.14.0
Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.6.1 to 1.7.0. - [Release notes](https://github.com/stretchr/testify/releases) - [Commits](stretchr/testify@v1.6.1...v1.7.0) --- updated-dependencies: - dependency-name: github.com/stretchr/testify dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [github.com/golang/mock](https://github.com/golang/mock) from 1.4.1 to 1.6.0. - [Release notes](https://github.com/golang/mock/releases) - [Changelog](https://github.com/golang/mock/blob/master/.goreleaser.yml) - [Commits](golang/mock@v1.4.1...v1.6.0) --- updated-dependencies: - dependency-name: github.com/golang/mock dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [github.com/Azure/go-autorest/autorest](https://github.com/Azure/go-autorest) from 0.11.18 to 0.11.19. - [Release notes](https://github.com/Azure/go-autorest/releases) - [Changelog](https://github.com/Azure/go-autorest/blob/master/CHANGELOG.md) - [Commits](Azure/go-autorest@autorest/v0.11.18...autorest/v0.11.19) --- updated-dependencies: - dependency-name: github.com/Azure/go-autorest/autorest dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…t/go_modules/github.com/stretchr/testify-1.7.0 chore(deps): bump github.com/stretchr/testify from 1.6.1 to 1.7.0
…t/go_modules/github.com/Azure/go-autorest/autorest-0.11.19 chore(deps): bump github.com/Azure/go-autorest/autorest from 0.11.18 to 0.11.19
Bumps [github.com/Azure/go-autorest/autorest/adal](https://github.com/Azure/go-autorest) from 0.9.13 to 0.9.14. - [Release notes](https://github.com/Azure/go-autorest/releases) - [Changelog](https://github.com/Azure/go-autorest/blob/master/CHANGELOG.md) - [Commits](Azure/go-autorest@autorest/adal/v0.9.13...autorest/adal/v0.9.14) --- updated-dependencies: - dependency-name: github.com/Azure/go-autorest/autorest/adal dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…t/go_modules/github.com/golang/mock-1.6.0 chore(deps): bump github.com/golang/mock from 1.4.1 to 1.6.0
Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.1.1 to 1.2.1. - [Release notes](https://github.com/spf13/cobra/releases) - [Changelog](https://github.com/spf13/cobra/blob/master/CHANGELOG.md) - [Commits](spf13/cobra@v1.1.1...v1.2.1) --- updated-dependencies: - dependency-name: github.com/spf13/cobra dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [github.com/onsi/ginkgo](https://github.com/onsi/ginkgo) from 1.11.0 to 1.16.4. - [Release notes](https://github.com/onsi/ginkgo/releases) - [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md) - [Commits](onsi/ginkgo@v1.11.0...v1.16.4) --- updated-dependencies: - dependency-name: github.com/onsi/ginkgo dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [k8s.io/cloud-provider](https://github.com/kubernetes/cloud-provider) from 0.22.1 to 0.22.2. - [Release notes](https://github.com/kubernetes/cloud-provider/releases) - [Commits](kubernetes/cloud-provider@v0.22.1...v0.22.2) --- updated-dependencies: - dependency-name: k8s.io/cloud-provider dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…t/go_modules/k8s.io/cloud-provider-0.22.2 chore(deps): bump k8s.io/cloud-provider from 0.22.1 to 0.22.2
openshift-ci
bot
added
the
needs-rebase
cloud-team-bot
bot
force-pushed
the
rebase-bot-master
branch
from
ffba951
to
e7a0317
Compare
openshift-ci
bot
removed
the
needs-rebase
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
doc: add one comment for node labeling rules
…ecific makefile extension, openshift specific hack scripts
…ecific makefile extension, openshift specific hack scripts
cloud-team-bot
bot
force-pushed
the
rebase-bot-master
branch
from
e7a0317
to
c49643c
Compare
|
@cloud-team-rebase-bot[bot]: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/close |
|
@Fedosin: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.