Use the correct ServiceAccount for the operator #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XS
|
/retest |
|
/hold |
openshift-ci-robot
added
do-not-merge/hold
|
/retest |
|
/test e2e-aws-operator |
The Role and RoleBinding were present in the CVO manifests, but the actual ServiceAccount for the operator was missing. In addition, a ClusterRole is needed for the cluster-scoped resource. This adds these, and updates the operator deployment.
openshift-ci-robot
added
size/M
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enxebre The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/lgtm |
ingvagabund
reviewed
Feb 4, 2019
| - apiGroups: | ||
| - cluster.k8s.io | ||
| resources: | ||
| - machinedeployments |
There was a problem hiding this comment.
+1 even though not yet supported
|
Don't think /lgtm |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The role and binding were present in the CVO manifests, but the
actual ServiceAccount was missing. This adds it, and configures the
operator deployment to use it.