Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ironic image for ironic-inspector #132

Merged
merged 1 commit into from Jul 1, 2021
Merged

Use ironic image for ironic-inspector #132

merged 1 commit into from Jul 1, 2021

Conversation

andfasano
Copy link
Contributor

@andfasano andfasano commented Apr 21, 2021 •
edited

This PR prepares CBO to accomodate the migration of Ironic Inspector into the Ironic image.

Requires metal3-io/ironic-image#253, openshift/ironic-image#179

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 21, 2021
@andfasano
Copy link
Contributor Author

/hold waiting for metal3-io/ironic-image#253

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 22, 2021
@iurygregory
Copy link
Contributor

Now that openshift/ironic-image#179 is merged I think we just need to fix the conflicts =)

@elfosardo
Copy link
Contributor

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 22, 2021
@dtantsur
Copy link
Member

Looks good, but needs a rebase.

Do we need to stop the inspector container if it's running for some reason?

@imain
Copy link
Contributor

imain commented Jun 25, 2021

LGTM. We've done this kind of thing in other projects too. It's mostly for the better I think.

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 25, 2021
@asalkeld asalkeld mentioned this pull request Jun 27, 2021
Merged
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 28, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 28, 2021
@andfasano
Copy link
Contributor Author

/test e2e-agnostic
/test e2e-metal-ipi-ovn-ipv6

@dhellmann
Copy link
Contributor

/uncc dhellmann

@openshift-ci openshift-ci bot removed the request for review from dhellmann June 29, 2021 13:09
@sadasu
Copy link
Contributor

sadasu commented Jun 29, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 29, 2021
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@andfasano
Copy link
Contributor Author

/test e2e-metal-ipi-ovn-ipv6

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 0638bdf into openshift:master Jul 1, 2021
@iurygregory iurygregory mentioned this pull request Sep 8, 2021
Merged
@hardys hardys mentioned this pull request Sep 13, 2021
Merged
derekhiggins added a commit to derekhiggins/installer that referenced this pull request Sep 13, 2021
@derekhiggins
baremetal: Specify entrypoint when starting inspector
5309d88 
Since openshift/ironic-image#190 the inspector components
and entrypoint moved to the ironic-image, so we need to
update the image and entrypoint to match, also aligning
with openshift/cluster-baremetal-operator#132
rvanderp3 pushed a commit to rvanderp3/installer that referenced this pull request Sep 17, 2021
@derekhiggins @rvanderp3
baremetal: Specify entrypoint when starting inspector
1f0263f 
Since openshift/ironic-image#190 the inspector components
and entrypoint moved to the ironic-image, so we need to
update the image and entrypoint to match, also aligning
with openshift/cluster-baremetal-operator#132
AnnaZivkovic pushed a commit to AnnaZivkovic/installer that referenced this pull request Apr 1, 2022
@derekhiggins
baremetal: Specify entrypoint when starting inspector
8b6f6df 
Since openshift/ironic-image#190 the inspector components
and entrypoint moved to the ironic-image, so we need to
update the image and entrypoint to match, also aligning
with openshift/cluster-baremetal-operator#132
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zaneb zaneb Awaiting requested review from zaneb

Assignees

@sadasu sadasu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@andfasano @openshift-ci-robot @iurygregory @elfosardo @dtantsur @imain @dhellmann @sadasu @openshift-bot @openshift-merge-robot