Merge ironic and ironic-inspector repositories #179
Conversation
openshift-ci
bot
added
the
approved
elfosardo
requested review from
iurygregory,
bfournie,
derekhiggins,
dtantsur,
lhh and
andfasano
elfosardo
force-pushed
the
merge-ironic-inspector
branch
from
31dfde7
to
7b16f96
Compare
|
/test prevalidation-e2e-metal-ipi-prevalidation |
openshift-ci
bot
added
the
needs-rebase
elfosardo
force-pushed
the
merge-ironic-inspector
branch
from
7b16f96
to
6c1d7fb
Compare
openshift-ci
bot
removed
the
needs-rebase
|
/retest |
|
I'm quite sure we'll need to do it together with some CBO changes. |
I don't think so, it doesn't change anything on ironic side, I'm just moving inspector config from the inspector repo to this one here |
|
/test prevalidation-e2e-metal-ipi-prevalidation |
1 similar comment
|
/test prevalidation-e2e-metal-ipi-prevalidation |
|
/test prevalidation-e2e-metal-ipi-virtualmedia-prevalidation |
|
/test prevalidation-e2e-metal-ipi-prevalidation |
|
/test prevalidation-e2e-metal-ipi-virtualmedia-prevalidation |
|
/test prevalidation-e2e-metal-ipi-prevalidation |
|
/retest |
1 similar comment
|
/retest |
|
/test prevalidation-e2e-metal-ipi-prevalidation |
|
/test prevalidation-e2e-metal-ipi-virtualmedia-prevalidation |
|
/test prevalidation-e2e-metal-ipi-prevalidation |
|
/test prevalidation-e2e-metal-ipi-prevalidation |
|
/retest |
1 similar comment
|
/retest |
elfosardo
force-pushed
the
merge-ironic-inspector
branch
from
6c1d7fb
to
54124c2
Compare
| do | ||
| until ls "${LOG_DIR}"/*.tar.gz 1> /dev/null 2>&1 | ||
| do | ||
| sleep 5 |
There was a problem hiding this comment.
We could potentially get stuck in this loop checking one directory and not swapping back to check the other.
e.g. if we are just redeploying nodes that have been previously inspected. Then this will get stuck waiting for a file
in /shared/log/ironic-inspector/ramdisk and never return to /shared/log/ironic/deploy
There was a problem hiding this comment.
I realize that, maybe we can do it as a follow-up?
we need to fix it first in https://github.com/metal3-io/ironic-image/blob/master/scripts/runlogwatch.sh
scripts/runlogwatch.sh
Outdated
| @@ -1,20 +1,24 @@ | |||
|
|
|||
There was a problem hiding this comment.
I think this newline might be the reason the CI tests are failing
Looking at the CI job logs, I noticed this to be failing
failed: (1.3s) 2021-06-18T10:05:50 "[sig-installer][Feature:baremetal] Baremetal platform should have a metal3 deployment [Suite:openshift/conformance/parallel]"
which fails if the replica set for the metal3 pod isn't 1
https://github.com/openshift/origin/blob/d389c2654/test/extended/baremetal/hosts.go#L72-L74
Looking at the must-gather, I could see that the "ironic-deploy-ramdisk-logs" was restarted 27 times, the logs for this container have an error
$ cat metal3-5444948969-w98zp/ironic-deploy-ramdisk-logs/ironic-deploy-ramdisk-logs/logs/current.log
2021-06-18T10:50:25.394447661Z standard_init_linux.go:219: exec user process caused: exec format error
There was a problem hiding this comment.
oh snap, I didn't see that! thanks!
This change moves Dockerfile, configuration and scripts from the ironic-inspector container image repository to the ironic one. This approach provides one Dockerfile that builds an image that contains all the services necessary to run both ironic and ironic-inspector. The scripts and configurations are kept separated for the time being. Those changes will need to be reflected in CI as well.
elfosardo
force-pushed
the
merge-ironic-inspector
branch
from
54124c2
to
b189e2b
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: derekhiggins, elfosardo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test prevalidation-e2e-metal-ipi-prevalidation |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Set the hash ring algorithm to SHA256
This change moves Dockerfile, configuration and scripts from the
ironic-inspector container image repository to the ironic one.
This approach provides one Dockerfile that builds an image that contains
all the services necessary to run both ironic and ironic-inspector.
The scripts and configurations are kept separated for the time being.
Those changes will need to be reflected in CI as well.