Bug 1813479: Tolerate all taints #171
Conversation
openshift-ci-robot
added
bugzilla/severity-high
|
@Miciah: This pull request references Bugzilla bug 1813479, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
approved
openshift-ci-robot
added
bugzilla/valid-bug
|
@Miciah: This pull request references Bugzilla bug 1813479, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
needs-rebase
Miciah
force-pushed
the
BZ1813479-tolerate-all-taints
branch
from
7539d0d
to
f396fd1
Compare
Configure the operand daemonset to tolerate all taints in order to accommodate user-set taints. This commit reverts 3eb10d0. This commit fixes bug 1813479. https://bugzilla.redhat.com/show_bug.cgi?id=1813479 * assets/dns/daemonset.yaml: Tolerate all taints. * pkg/manifests/bindata.go: Regenerate.
Miciah
force-pushed
the
BZ1813479-tolerate-all-taints
branch
from
f396fd1
to
75f81c8
Compare
openshift-ci-robot
removed
the
needs-rebase
|
/hold @derekwaynecarr did we get agreement to allow tolerating all taints Is there an enhancement / update that clarifies official stance of project on this? |
openshift-ci-robot
added
the
do-not-merge/hold
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danehans, Miciah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sorry to introduce MCO comments here, but we have the very same BZ (https://bugzilla.redhat.com/show_bug.cgi?id=1780318) for the MCD where we're asked to tolerate all taints and we have a PR to fix it as well. Tho, I'm definitely not sure what's the discussion here is about wrt to other system daemons. Is it always ok for things like MCD/DNS to tolerate all taints? |
|
Sorry, I should have posted an update to this PR. Currently we are building consensus and codifying the OpenShift project's conventions around taints and tolerations: openshift/enhancements#344 However, because we have not gotten these conventions codified yet and we have code freeze for the 4.5 release this Friday, we have deferred this fix to 4.6 with plans to backport the fix to 4.5.z (https://bugzilla.redhat.com/show_bug.cgi?id=1813479#c13). @runcom, maybe MCO can take the same course of action (defer to 4.6 and backport to 4.5.z). |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
@smarterclayton see conventions update: |
|
@Miciah: Some pull requests linked via external trackers have merged: openshift/cluster-dns-operator#171. The following pull requests linked via external trackers have not merged:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
|
@Miciah: Some pull requests linked via external trackers have merged: openshift/cluster-dns-operator#171. The following pull requests linked via external trackers have not merged:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
|
@Miciah: All pull requests linked via external trackers have merged: openshift/cluster-dns-operator#171. Bugzilla bug 1813479 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.4 |
|
@Miciah: #171 failed to apply on top of branch "release-4.4": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
It's un-cool to need to run dns-pods on all nodes. This makes it difficult when you have a zoned environment (different nodes in different VLANs), as requests (via the service) might be attempted towards a pod the node should not be able to communicate with. Also - running DNS everywhere is overkill - it should be sufficient to place on a few selected nodes with a shared-infra purpose for the entire cluster. With the default toleration which effectively ignores all taints this is not possible. Part of the problem seems to be that the "dns-pods" have a dual responsibility:
if the responsibility could be split, the pods could be scheduled differently. |
Configure the operand daemonset to tolerate all taints in order to accommodate user-set taints.
This PR reverts #140.
assets/dns/daemonset.yaml: Tolerate all taints.pkg/manifests/bindata.go: Regenerate.Supersedes #162.