Bug 1780318: MCD: tolerate all taints #1760
Conversation
Signed-off-by: Antonio Murdaca <runcom@linux.com>
openshift-ci-robot
added
bugzilla/severity-high
|
@runcom: This pull request references Bugzilla bug 1780318, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
approved
|
/bugzilla refresh |
openshift-ci-robot
added
bugzilla/invalid-bug
|
@runcom: This pull request references Bugzilla bug 1780318, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@runcom: This pull request references Bugzilla bug 1780318, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
1 similar comment
|
/retest |
|
@stbenjam ping for the metal-ipi e2e sort of constantly failing, can you help assess if this PR is breaking it or it's transient? |
|
/retest |
|
In theory I think this is correct. Should we skip 4.5 and put this into early 4.6 so to let the change of behaviour soak? I don't think this will break any existing clusters anyways. |
yep, BZ is already 4.6 and now that master is open we can get this in to test it out |
|
/skip |
|
/bugzilla refresh |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@runcom: This pull request references Bugzilla bug 1780318, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
removed
the
bugzilla/invalid-bug
all good now then |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: runcom, yuqi-zhang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
5 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@runcom: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@runcom: All pull requests linked via external trackers have merged: openshift/machine-config-operator#1760. Bugzilla bug 1780318 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.5 |
|
@runcom: new pull request created: #1814 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.4 |
|
@runcom: new pull request created: #1815 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.3 |
|
@runcom: new pull request created: #1816 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is supposed to fix the BZ in $subject and it's the same as BZs like https://bugzilla.redhat.com/show_bug.cgi?id=1813479. The impact of a change like this isn't fully clear as mentioned in the DNS PR as well openshift/cluster-dns-operator#171 (comment)
I'm opening this PR to get some more eyes and testing on this - @derekwaynecarr @smarterclayton ptal
The BZ has been pushed to 4.6 following what the DNS team did as well.