Fix logic for disabling/enabling leader election #202
Conversation
Prior to this commit, it was impossible to disable leader election because `LeaderElectID` was set to a specific value. In other words, setting `LeaderElectID` in `main.go` automatically enables leader election, even if you manually modify the relevant manifests to set the leader election to false. The only way to actually disable leader election is to create an if-else conditional that creates a manager *without* the leader election variables passed into the constructor.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: courtneypacheco The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/assign @ArangoGutierrez |
|
/retest-required |
|
Not sure if the problem is on our end, of if this is the right way to fix this |
openshift-ci
bot
added
the
do-not-merge/hold
|
/hold cancel |
|
/close |
|
@ArangoGutierrez: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Prior to this suggested PR, it was impossible to disable leader election because
LeaderElectIDwas set to a specific value. In other words, settingLeaderElectIDinmain.goautomatically enables leader election, even if you manually modify the relevant manifests to set the leader election to false. The only way to actually disable leader election is to create an if-else conditional that creates a manager without the leader election variables passed into the constructor.