CONSOLE-3654: console-plugin-template repository should support localization

[Mylanos]

Links to: https://issues.redhat.com/browse/CONSOLE-3654

Adds possibility to generate locales in the console-plugin-template repo.

[openshift-ci-robot]

@Mylanos: This pull request references CONSOLE-3654 which is a valid jira issue.

In response to this:

Links to: https://issues.redhat.com/browse/CONSOLE-3654

Adds possibility to generate locales in the console-plugin-template repo.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Mylanos]

/retest-required

[jhadvig]

  1) Console plugin template test
       "before all" hook for "Verify the example page title":
     CypressError: `cy.exec('cd ../../console-plugin-template && /tmp/helm upgrade -i console-plugin-template charts/openshift-console-plugin -n console-plugin-template --create-namespace --set plugin.image=registry.build01.ci.openshift.org/ci-op-q9b5jsxw/pipeline@sha256:619b1c4b96723afa7f5e21994f8c8c2abf7ca8450b508a07aee2a9aeac392061')` timed out after waiting `60000ms`.
https://on.cypress.io/exec
Because this error occurred during a `before all` hook we are skipping the remaining tests in the current suite: `Console plugin template test`
Although you have test retries enabled, we do not retry tests when `before all` or `after all` hooks fail

/retest

[Mylanos]

/retest

[jhadvig]

/retest

[Mylanos]

{Operator unavailable (null): operator is not reporting conditions Operator unavailable (null): operator is not reporting conditions}

{ openshift cluster install failed with cluster creation}

{ openshift cluster install failed overall}

[Mylanos]

/retest

[Mylanos]

/retest

[jhadvig]

One small nit, otherwise good to go 👍

[jhadvig]

Suggested change

	NOTE: Please adhere to the specified namespace format `plugin__<name-of-the-plugin>` when defining namespaces. The name of the plugin should be extracted from the `consolePlugin` declaration within the [package.json](package.json) file.
	NOTE: When defining i18n namespace, adhere `plugin__<name-of-the-plugin>` format. The name of the plugin should be extracted from the `consolePlugin` declaration within the [package.json](package.json) file.

[openshift-ci]

@Mylanos: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[jhadvig]

/lgtm
/approve

[jhadvig]

QE Approver:
/assign @yanpzhan

Docs Approver:
/assign @opayne1

PX Approver:
/assign @RickJWagner

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: jhadvig, Mylanos

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[RickJWagner]

/label px-approved

[opayne1]

/label docs-approved

[yanpzhan]

I run the plugin using a local development environment by:
In one terminal window, run:
yarn install
yarn run start
In another terminal window, run:
oc login
yarn run start-console
Then access "localhost:9000/example?pseudolocalization=true&lng=en", could see contents are marked for i18n.

@Mylanos If there others I need to check for the US?

[Mylanos]

I run the plugin using a local development environment by: In one terminal window, run: yarn install yarn run start In another terminal window, run: oc login yarn run start-console Then access "localhost:9000/example?pseudolocalization=true&lng=en", could see contents are marked for i18n. @Mylanos If there others I need to check for the US?

I'm sorry but I'm not sure if I understand correctly, could you please clarify the question?

[yanpzhan]

@Mylanos I mean except the check in above screenshot , if there are any other checkpoints I need to test for the feature from the pr code.

[Mylanos]

@Mylanos I mean except the check in above screenshot , if there are any other checkpoints I need to test for the feature from the pr code.

That's pretty much it, other than that the features that this PR brings is the locale/translations files and contents get automatically generated from source codes via yarn i18n, so you can check if all the strings inside the source code get translated after you remove the locale files. But that is closely tied with the check if all the strings on the example page are marked for i18n.

[yanpzhan]

@Mylanos Thanks. I tried to remove file:
# rm locales/en/plugin__console-plugin-template.json
# yarn i18n
After yarn i18n, the file under locals is generated again.
/label qe-approved

[openshift-ci]

@yanpzhan: The label(s) /label qe-approved. cannot be applied. These labels are supported: platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, downstream-change-needed, rebase/manual, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

@Mylanos Thanks. I tried to remove file:
# rm locales/en/plugin__console-plugin-template.json
# yarn i18n
After yarn i18n, the file under locals is generated again.
/label qe-approved.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[yanpzhan]

/label qe-approved