Bug 2008612: Proxy browser cache headers from plugin asset request #10153
Conversation
|
@jhadvig: This pull request references Bugzilla bug 2008612, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
bugzilla/severity-medium
|
/bugzilla refresh |
openshift-ci
bot
added
the
bugzilla/valid-bug
|
@jhadvig: This pull request references Bugzilla bug 2008612, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
removed
the
bugzilla/invalid-bug
openshift-ci
bot
added
the
approved
pkg/proxy/proxy.go
Outdated
| @@ -89,6 +89,15 @@ func decodeSubprotocol(encodedProtocol string) (string, error) { | |||
|
|
|||
| var headerBlacklist = []string{"Cookie", "X-CSRFToken"} | |||
|
|
|||
| // pass through headers that are needed for browser caching and content negotiation, | |||
| // except "Cookie" and "X-CSRFToken" headers. | |||
| func ProxyRequestHeaders(originalRequest, newRequest *http.Request) { | |||
There was a problem hiding this comment.
nit: I think CopyRequestHeaders is more accurate and clear.
|
@spadgett comment addressed 👍 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jhadvig, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@jhadvig: All pull requests linked via external trackers have merged: Bugzilla bug 2008612 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Proxying all the headers except
CookieandX-CSRFToken/assign @spadgett
/cherry-pick release-4.9