Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2020275: Fix ClusterOperators link #10409

Merged
merged 1 commit into from
Nov 9, 2021

Conversation

rebeccaalpert
Copy link
Contributor

The ClusterOperators link was returning "undefined" in the link it generated if no query string was passed in. I added a check for whether a query string is present.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2020275.

The ClusterOperators link was returning undefined in the link if no query string was passed in. I added a check for whether a query string is present to fix the bug.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2020275
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 8, 2021

@rebeccaalpert: An error was encountered querying GitHub for users with public email (yapei@redhat.com) for bug 2020275 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. non-200 OK status code: 403 Forbidden body: "{\n \"documentation_url\": \"https://docs.github.com/en/free-pro-team@latest/rest/overview/resources-in-the-rest-api#secondary-rate-limits\",\n \"message\": \"You have exceeded a secondary rate limit. Please wait a few minutes before you try again.\"\n}\n"

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

Bug 2020275: Fix ClusterOperators link

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the component/core Related to console core functionality label Nov 8, 2021
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 8, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rebeccaalpert, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2021
@rebeccaalpert
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci openshift-ci bot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Nov 8, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 8, 2021

@rebeccaalpert: This pull request references Bugzilla bug 2020275, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Nov 8, 2021
@openshift-ci openshift-ci bot requested a review from yapei November 8, 2021 20:57
@rebeccaalpert
Copy link
Contributor Author

/test e2e-gcp

@openshift-merge-robot openshift-merge-robot merged commit 12f1d93 into openshift:master Nov 9, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 9, 2021

@rebeccaalpert: All pull requests linked via external trackers have merged:

Bugzilla bug 2020275 has been moved to the MODIFIED state.

In response to this:

Bug 2020275: Fix ClusterOperators link

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rebeccaalpert
Copy link
Contributor Author

/cherry-pick release-4.9

@openshift-cherrypick-robot

@rebeccaalpert: new pull request created: #10417

In response to this:

/cherry-pick release-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.10 milestone Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants