Bug 2041093: Changed validation of adding file content from not empty to not contain parsing errors #10895
Conversation
openshift-ci
bot
added
the
bugzilla/severity-unspecified
|
@metalice: This pull request references Bugzilla bug 2041093, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
bugzilla/invalid-bug
openshift-ci
bot
added
component/kubevirt
|
/bugzilla refresh |
openshift-ci
bot
removed
the
bugzilla/severity-unspecified
|
@metalice: This pull request references Bugzilla bug 2041093, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
bugzilla/severity-medium
|
@pcbailey @glekner @avivtur @hstastna @upalatucci @vojtechszocs please review |
…in parsing errors Signed-off-by: Matan Schatzman <mschatzm@redhat.com>
metalice
force-pushed
the
bz-2041093-not-adding-empty-autounattend-or-unattend
branch
from
e22b2e6
to
024e956
Compare
|
/bugzilla refresh |
openshift-ci
bot
added
the
bugzilla/valid-bug
|
@metalice: This pull request references Bugzilla bug 2041093, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
removed
the
bugzilla/invalid-bug
|
/test kubevirt-plugin |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: avivtur, metalice The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@metalice: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@metalice: All pull requests linked via external trackers have merged: Bugzilla bug 2041093 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Matan Schatzman mschatzm@redhat.com
Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=2041093
Analysis / Root cause:
Empty xml file was providing null and would add to configmap.
Solution Description:
It will check if there isn't parsing XML errors, if none, it will be added, even if empty XML
Screen shots / Gifs for design review:
After:
Before:
