Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2042851: Create template from SAP HANA template flow #10899

Merged
merged 1 commit into from
Jan 25, 2022
Merged

Bug 2042851: Create template from SAP HANA template flow #10899

merged 1 commit into from
Jan 25, 2022

Conversation

avivtur
Copy link
Contributor

@avivtur avivtur commented Jan 20, 2022 •
edited
Loading

Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=2042851

Analysis / Root cause:
Missing flow to create a template from SAP HANA template

Solution Description:
Adding a flow to create a template from SAP HANA template and ridercting to template when finishes

Screen shots / Gifs for design review:

After:

after.mp4

Signed-off-by: Aviv Turgeman aturgema@redhat.com

@openshift-ci openshift-ci bot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jan 20, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 20, 2022

@avivtur: This pull request references Bugzilla bug 2042851, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 2042851: Create template from SAP HANA template flow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from gouyang January 20, 2022 17:36
@avivtur avivtur changed the title Bug 2042851: Create template from SAP HANA template flow [WIP] Bug 2042851: Create template from SAP HANA template flow Jan 20, 2022
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 20, 2022
@openshift-ci openshift-ci bot added component/kubevirt Related to kubevirt-plugin approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 20, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 23, 2022

@avivtur: This pull request references Bugzilla bug 2042851, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

[WIP] Bug 2042851: Create template from SAP HANA template flow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@avivtur avivtur changed the title [WIP] Bug 2042851: Create template from SAP HANA template flow Bug 2042851: Create template from SAP HANA template flow Jan 23, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 23, 2022
@yaacov
Copy link
Member

yaacov commented Jan 23, 2022

/retest

metalice
metalice reviewed Jan 23, 2022
View reviewed changes
...d/packages/kubevirt-plugin/src/components/vm-templates/instantiate-template/TemplateForm.tsx Outdated
@@ -45,6 +50,8 @@ export const TemplateForm: React.FC<TemplateFormProps> = ({
const [inProgress, setInProgress] = React.useState<boolean>(false);
const [errorMsg, setErrorMsg] = React.useState<string>('');

const isCreateTemplate = mode === VMWizardMode.TEMPLATE;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider using useMemo, it will recalc every render

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added thanks :)

...d/packages/kubevirt-plugin/src/components/vm-templates/instantiate-template/TemplateForm.tsx Outdated
const missingParams = Object.entries(parameters).filter(
([, value]) => !value || _.isEmpty(value),
);
const initValues = getParameterValues();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useMemo, also isnt it the same as line 63 initial value?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same :)

@avivtur
Bug 2042851: Create template from SAP HANA template flow
7d7043b 
Signed-off-by: Aviv Turgeman <aturgema@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 24, 2022

@avivtur: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@metalice
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 25, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 25, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, metalice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 427ee19 into openshift:master Jan 25, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 25, 2022

@avivtur: All pull requests linked via external trackers have merged:

Bugzilla bug 2042851 has been moved to the MODIFIED state.

In response to this:

Bug 2042851: Create template from SAP HANA template flow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metalice metalice metalice left review comments

@gouyang gouyang Awaiting requested review from gouyang

@mareklibra mareklibra Awaiting requested review from mareklibra

Assignees

@metalice metalice

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/kubevirt Related to kubevirt-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@avivtur @yaacov @metalice @openshift-merge-robot