Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve e2e test reliability #1160

Merged
merged 1 commit into from
Feb 2, 2019
Merged

Improve e2e test reliability #1160

merged 1 commit into from
Feb 2, 2019

Conversation

TheRealJon
Copy link
Member

@TheRealJon TheRealJon commented Jan 31, 2019 •
edited

Improves reliability of e2e tests.

  • Increase specificity on a few ambiguous element locators.
  • Add a condition to check for .co-m-loader elements on a page so that we can wait until they are all gone before proceeding.
  • Fix a few possible async race conditions
  • Use better names for created resources so that they can be more easily selected

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 31, 2019
spadgett
spadgett reviewed Feb 1, 2019
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @TheRealJon 👍

frontend/integration-tests/tests/crud.scenario.ts Outdated Show resolved Hide resolved
frontend/integration-tests/views/crud.view.ts Show resolved Hide resolved
@TheRealJon
Copy link
Member Author

/test console-e2e

jcaianirh
jcaianirh approved these changes Feb 1, 2019
View reviewed changes
Copy link
Member

@jcaianirh jcaianirh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks jon

@spadgett
Copy link
Member

spadgett commented Feb 1, 2019

I believe this will fix https://jira.coreos.com/browse/CONSOLE-1232

@spadgett spadgett mentioned this pull request Feb 1, 2019
Merged
@TheRealJon
Copy link
Member Author

@spadgett @alecmerdler I believe I have addressed all of the feedback.

spadgett
spadgett approved these changes Feb 1, 2019
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 1, 2019
@spadgett
Copy link
Member

spadgett commented Feb 1, 2019

/test all

@spadgett
Copy link
Member

spadgett commented Feb 1, 2019

/retest

@openshift-merge-robot openshift-merge-robot merged commit 257cd00 into openshift:master Feb 2, 2019
@TheRealJon TheRealJon deleted the test-flakes branch March 12, 2019 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecmerdler alecmerdler alecmerdler left review comments

@spadgett spadgett spadgett approved these changes

@jcaianirh jcaianirh jcaianirh approved these changes

@rhamilto rhamilto Awaiting requested review from rhamilto

@jhadvig jhadvig Awaiting requested review from jhadvig

Assignees

@spadgett spadgett

Labels
lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@TheRealJon @spadgett @alecmerdler @jcaianirh @openshift-ci-robot @openshift-merge-robot