CONSOLE-4056: Check if GettingStartedBanner capability is enabled #14285
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@jhadvig: This pull request references CONSOLE-4056 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-ci
bot
added
component/core
|
@jhadvig: This pull request references CONSOLE-4056 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@jhadvig: This pull request references CONSOLE-4056 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
jhadvig
force-pushed
the
CONSOLE-4056
branch
2 times, most recently
from
5683aaf
to
e7eb888
Compare
jhadvig
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
jhadvig
force-pushed
the
CONSOLE-4056
branch
from
e7eb888
to
66fa96b
Compare
|
/retest |
frontend/public/components/app.jsx
Outdated
| dispatch( | ||
| setFlag( | ||
| FLAGS.CONSOLE_CAPABILITY_GETTINGSTARTEDBANNER_IS_ENABLED, | ||
| gettingStartedBannerCapability?.visibility?.state === 'Enabled' ? true : false, |
There was a problem hiding this comment.
Looks good, except for this nit: I think the ternary operator is unnecessary in this case since the expression gettingStartedBannerCapability?.visibility?.state === 'Enabled' always evaluates to a boolean value.
jhadvig
force-pushed
the
CONSOLE-4056
branch
from
795332f
to
c1dec6c
Compare
|
@jhadvig: This pull request references CONSOLE-4056 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@jhadvig: This pull request references CONSOLE-4056 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
| const consoleCommitChanged = prevUpdateData?.consoleCommit !== updateData?.consoleCommit; | ||
| if (stateInitialized && consoleCommitChanged && !consoleChanged) { | ||
|
|
||
| if (stateInitialized && (consoleCommitChanged || consoleCapabilitiesChanged) && !consoleChanged) { |
There was a problem hiding this comment.
I think the addition have be included in the story AC?
There was a problem hiding this comment.
yes, I've just noticed it when addressing your comment 👍
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cyril-ui-developer, jhadvig The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/label px-approved |
openshift-ci
bot
added
the
px-approved
|
/label docs-approved |
openshift-ci
bot
added
the
docs-approved
|
@jhadvig one some question, if I change the value of GettingStartedBanner using |
|
@XiyunZhao no a manual change is not being reflected in the console. |
|
Thanks for the quick reply, no other issue was found on this PR |
openshift-ci
bot
added
the
qe-approved
|
@jhadvig: This pull request references CONSOLE-4056 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@jhadvig: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[ART PR BUILD NOTIFIER] Distgit: openshift-enterprise-console |
Adding implementation to check the
SERVER_FLAGS.capabilities, if theGettingStartedBannervisibility is:Enabledwhich will render the bannerDisabledwhich will not render the bannerEdit: Upon capabilities change the
Web console update is availablepopup should be rendered in order to notify user to refresh the page.Also Adding e2e test.
/assign @cyril-ui-developer