-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CONSOLE-2361: Update react-catalog-view-extension to version that does not require PatternFly 3 #9419
CONSOLE-2361: Update react-catalog-view-extension to version that does not require PatternFly 3 #9419
Conversation
36f7de3
to
62371ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold See patternfly/patternfly#4155 (comment) I think we should wait for the revert, and then the override I added won't be necessary. |
Tested the pr, did some regression test on operatorhub page and catalog page. Didn't find issue. |
@yanpzhan, I don't think a second QE test is necessary since the gist of this PR is to migrate to a version of react-catalog-view-extension that does not include Bootstrap/PatternFly 3 as a dependency, which will not require retesting. |
62371ba
to
c751345
Compare
c751345
to
a8e8c20
Compare
a8e8c20
to
23e3413
Compare
@@ -1,5 +1,4 @@ | |||
// Use this file to override styles from 3rd party dependencies | |||
$pf-4-nav-bar-height: 76px; // Height of the PatternFly 4 masthead |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/label qe-approved |
53bf1ca
to
1493dea
Compare
/hold cancel The PatternFly regression was reverted, and this PR now makes use of the PatternFly version without the regression. |
/retest |
It looks like the catalog extension is getting pulled into the main vendor bundle causing the analyze job failure. |
Or maybe just Patternfly is a little bigger, and we went over the max. |
I'm thinking this must be the case as I can't see a change that would result in a difference. |
See #9069 (comment). We added a new library, but didn't increase the vendor bundle limit enough IMO. |
Let's increase the limit to something like 3.25MB for now and we can revisit whether we want to lazy load the quick starts library separately. cc @jschuler |
…s not require PatternFly 3
1493dea
to
d2f161c
Compare
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtaylor113, rhamilto, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR should result in no significant changes in the rendering of the catalog, but migrate us to a version of react-catalog-view-extension that does not include Bootstrap/PatternFly 3 as a dependency.
Notes:
FilterSidePanelCategoryItem
, but the difference is negligible.