Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONSOLE-2361: Remove orphaned patternfly-react 3 styles and patternfly-react 3 depe… #9452

Conversation

rhamilto
Copy link
Member

@rhamilto rhamilto commented Jul 8, 2021

…ndency

I assume these packages updated to the patternfly-react 4 equivalents, but left behind the patternfly-react 3 css, orphaning the css and maintaining the dependency on patternfly-react 3. This fixes that oversight.

cc: @sg00dwin @jcaianirh @glekner

@openshift-ci openshift-ci bot requested review from jelkosz and kyoto July 8, 2021 20:14
@openshift-ci openshift-ci bot added component/core Related to console core functionality component/kubevirt Related to kubevirt-plugin approved Indicates a PR has been approved by an approver from all required OWNERS files. component/olm Related to OLM labels Jul 8, 2021
Copy link
Member

@jcaianirh jcaianirh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@spadgett spadgett changed the title Remove orphaned patternfly-react 3 styles and patternfly-react 3 depe… CONSOLE-2361: Remove orphaned patternfly-react 3 styles and patternfly-react 3 depe… Jul 8, 2021
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold for approvals
/assign @yapei

@yapei We just need a regression test to make sure there are no visual problems removing this dependency.

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Jul 8, 2021
@sferich888
Copy link

/label px-approved
/unassign @sferich888

@openshift-ci openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Jul 9, 2021
@rhamilto rhamilto force-pushed the remove-orphaned-pf3-react-styles branch from 2ea47a3 to f9e6b0d Compare July 9, 2021 18:34
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2021
@XiyunZhao
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jul 13, 2021
@XiyunZhao
Copy link

This changes is verified, it's not impacted the relgular function and page on private build.

@spadgett
Copy link
Member

There are no user visible changes. Adding the docs-approved label.

/label docs-approved

@ahardin-rh FYI

@openshift-ci openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Jul 13, 2021
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 13, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 13, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcaianirh, rhamilto, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhamilto
Copy link
Member Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 14, 2021
@spadgett spadgett added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/dependency-change Categorizes issue or PR as related to changing dependencies labels Jul 14, 2021
@openshift-merge-robot openshift-merge-robot merged commit f0abfbd into openshift:master Jul 14, 2021
@rhamilto rhamilto deleted the remove-orphaned-pf3-react-styles branch July 14, 2021 19:49
@spadgett spadgett added this to the v4.9 milestone Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/kubevirt Related to kubevirt-plugin component/olm Related to OLM docs-approved Signifies that Docs has signed off on this PR kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/dependency-change Categorizes issue or PR as related to changing dependencies lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants