New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CONSOLE-2361: Remove orphaned patternfly-react 3 styles and patternfly-react 3 depe… #9452
CONSOLE-2361: Remove orphaned patternfly-react 3 styles and patternfly-react 3 depe… #9452
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/label px-approved |
2ea47a3
to
f9e6b0d
Compare
I realized there were additional unnecessary imports in https://github.com/openshift/console/pull/9452/files#diff-e4dab90fda631807abb5c876d5926e380851139a8ea5ca96b04638e32e03aafcL1-L12 and https://github.com/openshift/console/pull/9452/files#diff-ff6bbd646f75df45d59a89f387ce5622a78d264af33f7e117388fd8ab4a86d92L3-L10. Please retag, @spadgett |
/label qe-approved |
This changes is verified, it's not impacted the relgular function and page on private build. |
There are no user visible changes. Adding the docs-approved label. /label docs-approved @ahardin-rh FYI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcaianirh, rhamilto, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
…ndency
I assume these packages updated to the patternfly-react 4 equivalents, but left behind the patternfly-react 3 css, orphaning the css and maintaining the dependency on patternfly-react 3. This fixes that oversight.
cc: @sg00dwin @jcaianirh @glekner