Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving block pool cypress testcases to ODF console #9992

Merged
merged 1 commit into from
Dec 21, 2021
Merged

Moving block pool cypress testcases to ODF console #9992

merged 1 commit into from
Dec 21, 2021

Conversation

GowthamShanmugam
Copy link
Contributor

Signed-off-by: Gowtham Shanmugasundaram gshanmug@redhat.com

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 3, 2021
@openshift-ci openshift-ci bot added the component/ceph Related to ceph-storage-plugin label Sep 3, 2021
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 3, 2021
@bipuladh
Copy link
Contributor

Let's not remove the tests until we completely move the code from here to ODF. Please update the data-test only.

@GowthamShanmugam
Copy link
Contributor Author

Let's not remove the tests until we completely move the code from here to ODF. Please update the data-test only.

ack

@GowthamShanmugam GowthamShanmugam force-pushed the e2e_for_block_pool_dashboad branch 2 times, most recently from 76b49c4 to 65699bc Compare September 29, 2021 22:43
@openshift-ci openshift-ci bot added component/dashboard Related to dashboard component/shared Related to console-shared labels Sep 29, 2021
@GowthamShanmugam GowthamShanmugam mentioned this pull request Sep 29, 2021
Closed
@GowthamShanmugam GowthamShanmugam force-pushed the e2e_for_block_pool_dashboad branch 5 times, most recently from 6d5b189 to 9b57a39 Compare December 15, 2021 20:14
bipuladh
bipuladh reviewed Dec 16, 2021
View reviewed changes
Copy link
Contributor

@bipuladh bipuladh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not disable them until we move to 4.11 for ODF.

frontend/packages/ceph-storage-plugin/integration-tests-cypress/tests/block-pool-create.spec.ts
@@ -1,7 +1,8 @@
import { checkErrors } from '../../../integration-tests-cypress/support';
import { createBlockPool, deleteBlockPoolFromCli } from '../views/block-pool';

describe('Test block pool creation under OCS UI', () => {
/** @depricated testcases are moved to odf-console */
xdescribe('Test block pool creation under OCS UI', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
xdescribe('Test block pool creation under OCS UI', () => {
describe('Test block pool creation under OCS UI', () => {

frontend/packages/ceph-storage-plugin/integration-tests-cypress/tests/block-pool-delete.spec.ts
@@ -13,7 +13,8 @@ import { createStorageClass } from '../views/storage-class';

const pvcName: string = 'testing-pvc';

describe('Test block pool deletion under OCS UI', () => {
/** @depricated testcases are moved to odf-console */
xdescribe('Test block pool deletion under OCS UI', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
xdescribe('Test block pool deletion under OCS UI', () => {
describe('Test block pool deletion under OCS UI', () => {

frontend/packages/ceph-storage-plugin/integration-tests-cypress/tests/block-pool-update.spec.ts
@@ -9,7 +9,8 @@ import {
poolMessage,
} from '../views/block-pool';

describe('Test block pool update under OCS UI', () => {
/** @depricated testcases are moved to odf-console */
xdescribe('Test block pool update under OCS UI', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
xdescribe('Test block pool update under OCS UI', () => {
describe('Test block pool update under OCS UI', () => {

frontend/packages/ceph-storage-plugin/integration-tests-cypress/tests/multiple-pool.spec.ts
@@ -36,7 +36,7 @@ const createBlockPool = (poolCreationAction: string) => {
verifyBlockPoolJSON();
};

// Todo(bipuladh): Enable after downstream builds are available with v1 CSIDrivers
/** @depricated testcases are moved to odf-console */
xdescribe('Test Ceph pool creation', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
xdescribe('Test Ceph pool creation', () => {
describe('Test Ceph pool creation', () => {

@GowthamShanmugam
Block pool e2e testing
2068ee9 
Block pool pages are moved under odf-console and test cases are
migrated to odf-console.

Signed-off-by: Gowtham Shanmugasundaram <gshanmug@redhat.com>
@bipuladh
Copy link
Contributor

/approve
/lgtm
/px-approved
/qe-approved
/docs-approved
Test changes only

@bipuladh
Copy link
Contributor

/label px-approved
/label qe-approved
/label docs-approved

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Dec 16, 2021
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2021
@bipuladh
Copy link
Contributor

/approve

bipuladh
bipuladh reviewed Dec 17, 2021
View reviewed changes
frontend/packages/console-shared/src/components/dashboard/details-card/DetailItem.tsx
</dt>
<dd
className={classNames('co-details-card__item-value', valueClassName)}
data-test="detail-item-value"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rawagner PTAL

@GowthamShanmugam
Copy link
Contributor Author

/retest

@rawagner
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 21, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bipuladh, GowthamShanmugam, rawagner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 21, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 21, 2021

@GowthamShanmugam: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 2f85e25 into openshift:master Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bipuladh bipuladh bipuladh left review comments

@shyRozen shyRozen Awaiting requested review from shyRozen

Assignees

@bipuladh bipuladh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/ceph Related to ceph-storage-plugin component/dashboard Related to dashboard component/shared Related to console-shared docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@GowthamShanmugam @bipuladh @rawagner @openshift-bot @openshift-merge-robot