Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert topology operator backed panel to use dynamic extensions #9998

Merged
merged 3 commits into from
Oct 6, 2021
Merged

convert topology operator backed panel to use dynamic extensions #9998

merged 3 commits into from
Oct 6, 2021

Conversation

sahil143
Copy link
Contributor

@sahil143 sahil143 commented Sep 6, 2021

fixes: https://issues.redhat.com/browse/ODC-5846, task: https://issues.redhat.com/browse/ODC-6114

This PR

  • converts topology operator backed panel to use dynamic extensions
  • Migrate CSV default action to use new Action Provider extension
  • Defined a new context csv-actions for operator backed
  • migrated ceph-storage-plugin actions to use new action extensions

Screenshot:
image

@openshift-ci openshift-ci bot added component/olm Related to OLM component/topology Related to topology kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels Sep 6, 2021
@invincibleJai
Copy link
Member

/cc @bipuladh

@sahil143
Copy link
Contributor Author

/retest

vikram-raj
vikram-raj reviewed Sep 23, 2021
View reviewed changes
Copy link
Member

@vikram-raj vikram-raj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verified it and it works as expected.

rohitkrai03
rohitkrai03 suggested changes Sep 28, 2021
View reviewed changes
frontend/packages/ceph-storage-plugin/console-extensions.json
{
"type": "console.action/provider",
"properties": {
"contextId": "csv-actions",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason to use a new context id for CSVs? Wouldn't CSV resource actions work here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use console.action/resource-provider extension?

Copy link
Contributor Author

@sahil143 sahil143 Sep 29, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have common actions Delete, Edit yaml that shows up on each operator backed resources that's why used a different context id https://github.com/openshift/console/pull/9998/files#diff-9993fe676fb030dc047b550a63b46524797154b76f9ff27cf33d8abc24233081R11-R12

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 30, 2021
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 1, 2021
@invincibleJai
Copy link
Member

/retest

@invincibleJai
Copy link
Member

/approve

verified the changes. I see missing i18n on list view react_devtools_backend.js:4049 Missing i18n key "Operator Backed Service" in namespace "public" and language "en."

This happens even on main, will be nice if we get it handled.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 4, 2021
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 5, 2021
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 5, 2021
rottencandy
rottencandy approved these changes Oct 6, 2021
View reviewed changes
Copy link
Contributor

@rottencandy rottencandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 6, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 6, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: invincibleJai, rottencandy, sahil143

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sahil143
Copy link
Contributor Author

sahil143 commented Oct 6, 2021

Propagate from epic:

/label px-approved
/label docs-approved

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Oct 6, 2021
@rottencandy
Copy link
Contributor

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Oct 6, 2021
@openshift-merge-robot openshift-merge-robot merged commit 07d1c20 into openshift:master Oct 6, 2021
@spadgett spadgett added this to the v4.10 milestone Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikram-raj vikram-raj vikram-raj left review comments

@rohitkrai03 rohitkrai03 rohitkrai03 requested changes

@rottencandy rottencandy rottencandy approved these changes

@bipuladh bipuladh Awaiting requested review from bipuladh

@christianvogt christianvogt Awaiting requested review from christianvogt

Assignees

@rottencandy rottencandy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/ceph Related to ceph-storage-plugin component/olm Related to OLM component/topology Related to topology docs-approved Signifies that Docs has signed off on this PR kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
v4.10
Development

Successfully merging this pull request may close these issues.
8 participants
@sahil143 @invincibleJai @rottencandy @vikram-raj @rohitkrai03 @christianvogt @spadgett @openshift-merge-robot