Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-30620: move test manifests to top-level directory #194

Merged

Conversation

dobsonj
Copy link
Member

@dobsonj dobsonj commented Mar 7, 2024

This PR copies the test manifests from the legacy dir to a top-level test dir so we can eventually remove the legacy dir (after updating CI jobs).

$ cp legacy/aws-ebs-csi-driver-operator/test/e2e/manifest.yaml test/e2e/aws-ebs/
$ cp legacy/azure-disk-csi-driver-operator/test/e2e/manifest.yaml test/e2e/azure-disk/
$ cp legacy/azure-file-csi-driver-operator/test/e2e/manifest.yaml test/e2e/azure-file/

Also remove the legacy test-unit and verify targets from the Makefile (we should be running these against the code we compile instead).

/cc @openshift/storage

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 7, 2024
@openshift-ci-robot
Copy link

@dobsonj: This pull request explicitly references no jira issue.

In response to this:

This PR just copies the test manifests from the legacy dir to a top-level test dir so we can eventually remove the legacy dir (after updating CI jobs).

$ cp legacy/aws-ebs-csi-driver-operator/test/e2e/manifest.yaml test/e2e/aws-ebs/
$ cp legacy/azure-disk-csi-driver-operator/test/e2e/manifest.yaml test/e2e/azure-disk/
$ cp legacy/azure-file-csi-driver-operator/test/e2e/manifest.yaml test/e2e/azure-file/

/cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Mar 7, 2024

@dobsonj: GitHub didn't allow me to request PR reviews from the following users: openshift/storage.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

This PR just copies the test manifests from the legacy dir to a top-level test dir so we can eventually remove the legacy dir (after updating CI jobs).

$ cp legacy/aws-ebs-csi-driver-operator/test/e2e/manifest.yaml test/e2e/aws-ebs/
$ cp legacy/azure-disk-csi-driver-operator/test/e2e/manifest.yaml test/e2e/azure-disk/
$ cp legacy/azure-file-csi-driver-operator/test/e2e/manifest.yaml test/e2e/azure-file/

/cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

openshift-ci bot commented Mar 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dobsonj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2024
@dobsonj
Copy link
Member Author

dobsonj commented Mar 8, 2024

/retest-required

Copy link
Contributor

openshift-ci bot commented Mar 8, 2024

@dobsonj: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-file-csi-extended e0b545a link false /test e2e-azure-file-csi-extended
ci/prow/e2e-azurestack-csi e0b545a link false /test e2e-azurestack-csi
ci/prow/e2e-azure-csi-extended e0b545a link false /test e2e-azure-csi-extended

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jsafrane
Copy link
Contributor

jsafrane commented Mar 8, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 8, 2024
@jsafrane
Copy link
Contributor

jsafrane commented Mar 8, 2024

/retitle STOR-1797: move test manifests to top-level directory

@openshift-ci openshift-ci bot changed the title NO-JIRA: move test manifests to top-level directory STOR-1797: move test manifests to top-level directory Mar 8, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 8, 2024

@dobsonj: This pull request references STOR-1797 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

This PR copies the test manifests from the legacy dir to a top-level test dir so we can eventually remove the legacy dir (after updating CI jobs).

$ cp legacy/aws-ebs-csi-driver-operator/test/e2e/manifest.yaml test/e2e/aws-ebs/
$ cp legacy/azure-disk-csi-driver-operator/test/e2e/manifest.yaml test/e2e/azure-disk/
$ cp legacy/azure-file-csi-driver-operator/test/e2e/manifest.yaml test/e2e/azure-file/

Also remove the legacy test-unit and verify targets from the Makefile (we should be running these against the code we compile instead).

/cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jsafrane
Copy link
Contributor

jsafrane commented Mar 8, 2024

/retitle OCPBUGS-30620: move test manifests to top-level directory

@openshift-ci openshift-ci bot changed the title STOR-1797: move test manifests to top-level directory OCPBUGS-30620: move test manifests to top-level directory Mar 8, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Mar 8, 2024
@openshift-ci-robot
Copy link

@dobsonj: This pull request references Jira Issue OCPBUGS-30620, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This PR copies the test manifests from the legacy dir to a top-level test dir so we can eventually remove the legacy dir (after updating CI jobs).

$ cp legacy/aws-ebs-csi-driver-operator/test/e2e/manifest.yaml test/e2e/aws-ebs/
$ cp legacy/azure-disk-csi-driver-operator/test/e2e/manifest.yaml test/e2e/azure-disk/
$ cp legacy/azure-file-csi-driver-operator/test/e2e/manifest.yaml test/e2e/azure-file/

Also remove the legacy test-unit and verify targets from the Makefile (we should be running these against the code we compile instead).

/cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 1260356 into openshift:master Mar 8, 2024
15 of 18 checks passed
@openshift-ci-robot
Copy link

@dobsonj: Jira Issue OCPBUGS-30620: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-30620 has been moved to the MODIFIED state.

In response to this:

This PR copies the test manifests from the legacy dir to a top-level test dir so we can eventually remove the legacy dir (after updating CI jobs).

$ cp legacy/aws-ebs-csi-driver-operator/test/e2e/manifest.yaml test/e2e/aws-ebs/
$ cp legacy/azure-disk-csi-driver-operator/test/e2e/manifest.yaml test/e2e/azure-disk/
$ cp legacy/azure-file-csi-driver-operator/test/e2e/manifest.yaml test/e2e/azure-file/

Also remove the legacy test-unit and verify targets from the Makefile (we should be running these against the code we compile instead).

/cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-azure-file-csi-driver-operator-container-v4.16.0-202403081048.p0.g1260356.assembly.stream.el9 for distgit azure-file-csi-driver-operator.
All builds following this will include this PR.

@duanwei33
Copy link

Checked e2e-azure-file-csi-extended and e2e-azure-csi-extended job, I found a lot of case failures on mount volume:
RawError: azure.BearerAuthorizer#WithAuthorization: Failed to refresh the Token for request to https://management.azure.com
I'm not sure if it is an env issue caused by credentials expired, just rerun the test to check further.

/test e2e-azure-file-csi-extended
/test e2e-azure-csi-extended

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants