Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-30620: remove legacy directory and duplicate Dockerfile.*.test files #196

Merged
merged 2 commits into from Mar 13, 2024

Conversation

dobsonj
Copy link
Member

@dobsonj dobsonj commented Mar 7, 2024

Remove legacy directory and duplicate test Dockerfiles after the following PR's merge:

#194
openshift/release#49655

/hold
/cc @openshift/storage

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 7, 2024
@openshift-ci-robot
Copy link

@dobsonj: This pull request explicitly references no jira issue.

In response to this:

Remove legacy directory and duplicate test Dockerfiles after the following PR's merge:

#194
#195
openshift/release#49655

/hold
/cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 7, 2024
Copy link
Contributor

openshift-ci bot commented Mar 7, 2024

@dobsonj: GitHub didn't allow me to request PR reviews from the following users: openshift/storage.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Remove legacy directory and duplicate test Dockerfiles after the following PR's merge:

#194
#195
openshift/release#49655

/hold
/cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

openshift-ci bot commented Mar 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dobsonj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2024
@dobsonj
Copy link
Member Author

dobsonj commented Mar 8, 2024

/retitle OCPBUGS-30620: remove legacy directory and duplicate Dockerfile.*.test files

@openshift-ci openshift-ci bot changed the title NO-JIRA: remove legacy directory and duplicate Dockerfile.*.test files OCPBUGS-30620: remove legacy directory and duplicate Dockerfile.*.test files Mar 8, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Mar 8, 2024
@openshift-ci-robot
Copy link

@dobsonj: This pull request references Jira Issue OCPBUGS-30620, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Remove legacy directory and duplicate test Dockerfiles after the following PR's merge:

#194
#195
openshift/release#49655

/hold
/cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dobsonj
Copy link
Member Author

dobsonj commented Mar 12, 2024

/test all

@dobsonj
Copy link
Member Author

dobsonj commented Mar 12, 2024

/retest-required

@jsafrane
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 13, 2024
@dobsonj
Copy link
Member Author

dobsonj commented Mar 13, 2024

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 13, 2024
Copy link
Contributor

openshift-ci bot commented Mar 13, 2024

@dobsonj: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-csi-extended 07c7888 link false /test e2e-azure-csi-extended
ci/prow/e2e-azure-file-csi-extended 07c7888 link false /test e2e-azure-file-csi-extended
ci/prow/e2e-azurestack-csi 07c7888 link false /test e2e-azurestack-csi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 1b3c72e and 2 for PR HEAD 07c7888 in total

@openshift-merge-bot openshift-merge-bot bot merged commit 75eeb24 into openshift:master Mar 13, 2024
15 of 18 checks passed
@openshift-ci-robot
Copy link

@dobsonj: Jira Issue OCPBUGS-30620: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-30620 has been moved to the MODIFIED state.

In response to this:

Remove legacy directory and duplicate test Dockerfiles after the following PR's merge:

#194
openshift/release#49655

/hold
/cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants