Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-30620: csi-operator: clean up legacy test manifests #49655

Merged
merged 2 commits into from Mar 12, 2024

Conversation

dobsonj
Copy link
Member

@dobsonj dobsonj commented Mar 7, 2024

This updates the step-registry to use test manifests from the top-level directory of csi-operator, and builds the test images from a common Dockerfile.test. The intent is to eventually remove the legacy directory in this repo.

/hold
for openshift/csi-operator#194

/cc @openshift/storage

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 7, 2024
Copy link
Contributor

openshift-ci bot commented Mar 7, 2024

@dobsonj: GitHub didn't allow me to request PR reviews from the following users: openshift/storage.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

This updates the step-registry to use test manifests from the top-level directory of csi-operator, and builds the test images from a common Dockerfile.test. The intent is to eventually remove the legacy directory in this repo.

/hold
for openshift/csi-operator#194 and openshift/csi-operator#195 to merge first

/cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2024
@jsafrane
Copy link
Contributor

jsafrane commented Mar 8, 2024

/retitle OCPBUGS-30620: csi-operator: clean up legacy test manifests

@openshift-ci openshift-ci bot changed the title csi-operator: clean up legacy test manifests OCPBUGS-30620: csi-operator: clean up legacy test manifests Mar 8, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 8, 2024
@openshift-ci-robot
Copy link
Contributor

@dobsonj: This pull request references Jira Issue OCPBUGS-30620, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This updates the step-registry to use test manifests from the top-level directory of csi-operator, and builds the test images from a common Dockerfile.test. The intent is to eventually remove the legacy directory in this repo.

/hold
for openshift/csi-operator#194 and openshift/csi-operator#195 to merge first

/cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Mar 8, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 8, 2024
@openshift-ci-robot
Copy link
Contributor

@dobsonj: This pull request references Jira Issue OCPBUGS-30620, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request.

In response to this:

This updates the step-registry to use test manifests from the top-level directory of csi-operator, and builds the test images from a common Dockerfile.test. The intent is to eventually remove the legacy directory in this repo.

/hold
for openshift/csi-operator#194

/cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@dobsonj: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cloud-provider-azure-release-4.13-e2e-azure-ovn-ccm openshift/cloud-provider-azure presubmit Registry content changed
pull-ci-openshift-cloud-provider-azure-release-4.12-e2e-azure-ccm openshift/cloud-provider-azure presubmit Registry content changed
pull-ci-openshift-cloud-provider-azure-release-4.11-e2e-azure-ccm openshift/cloud-provider-azure presubmit Registry content changed
pull-ci-openshift-cloud-provider-azure-release-4.10-e2e-azure-ccm openshift/cloud-provider-azure presubmit Registry content changed
pull-ci-openshift-cloud-provider-azure-release-4.9-e2e-azure-ccm openshift/cloud-provider-azure presubmit Registry content changed
pull-ci-openshift-cloud-provider-azure-release-4.11-openshift-e2e-azure-ccm-install openshift/cloud-provider-azure presubmit Registry content changed
pull-ci-openshift-cloud-provider-azure-release-4.10-openshift-e2e-azure-ccm-install openshift/cloud-provider-azure presubmit Registry content changed
pull-ci-openshift-cloud-provider-azure-release-4.9-openshift-e2e-azure-ccm-install openshift/cloud-provider-azure presubmit Registry content changed
pull-ci-openshift-origin-master-e2e-aws-csi openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.17-e2e-aws-csi openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.16-e2e-aws-csi openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.15-e2e-aws-csi openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.14-e2e-aws-csi openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.13-e2e-aws-csi openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.12-e2e-aws-csi openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.11-e2e-aws-csi openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.10-e2e-aws-csi openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.9-e2e-aws-csi openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.8-e2e-aws-csi openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.7-e2e-aws-csi openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.6-e2e-aws-csi openshift/origin presubmit Registry content changed
pull-ci-openshift-csi-operator-master-e2e-aws-csi openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-master-e2e-aws-csi-extended openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-master-e2e-aws-ovn-upgrade openshift/csi-operator presubmit Ci-operator config changed
pull-ci-openshift-csi-operator-master-e2e-azure openshift/csi-operator presubmit Ci-operator config changed

A total of 266 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@dobsonj
Copy link
Member Author

dobsonj commented Mar 8, 2024

/pj-rehearse max

@jsafrane
Copy link
Contributor

/pj-rehearse

@jsafrane
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 12, 2024
Copy link
Contributor

openshift-ci bot commented Mar 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dobsonj, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dobsonj
Copy link
Member Author

dobsonj commented Mar 12, 2024

/pj-rehearse pull-ci-openshift-origin-release-4.15-e2e-aws-csi pull-ci-openshift-origin-release-4.14-e2e-aws-csi

1 similar comment
@dobsonj
Copy link
Member Author

dobsonj commented Mar 12, 2024

/pj-rehearse pull-ci-openshift-origin-release-4.15-e2e-aws-csi pull-ci-openshift-origin-release-4.14-e2e-aws-csi

Copy link
Contributor

openshift-ci bot commented Mar 12, 2024

@dobsonj: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/azure-disk-csi-driver-operator/release-4.11/e2e-azure-csi b9438cd link unknown /pj-rehearse pull-ci-openshift-azure-disk-csi-driver-operator-release-4.11-e2e-azure-csi
ci/rehearse/openshift/azure-disk-csi-driver-operator/release-4.15/e2e-azurestack-csi b9438cd link unknown /pj-rehearse pull-ci-openshift-azure-disk-csi-driver-operator-release-4.15-e2e-azurestack-csi
ci/rehearse/openshift/csi-operator/master/e2e-azurestack-csi b9438cd link unknown /pj-rehearse pull-ci-openshift-csi-operator-master-e2e-azurestack-csi
ci/rehearse/openshift/azure-disk-csi-driver-operator/release-4.14/e2e-azurestack-csi b9438cd link unknown /pj-rehearse pull-ci-openshift-azure-disk-csi-driver-operator-release-4.14-e2e-azurestack-csi
ci/rehearse/openshift/azure-disk-csi-driver-operator/release-4.13/e2e-azurestack-csi b9438cd link unknown /pj-rehearse pull-ci-openshift-azure-disk-csi-driver-operator-release-4.13-e2e-azurestack-csi
ci/rehearse/openshift/csi-operator/master/e2e-azure-manual-oidc b9438cd link unknown /pj-rehearse pull-ci-openshift-csi-operator-master-e2e-azure-manual-oidc
ci/rehearse/openshift/azure-disk-csi-driver-operator/release-4.10/e2e-azurestack-csi b9438cd link unknown /pj-rehearse pull-ci-openshift-azure-disk-csi-driver-operator-release-4.10-e2e-azurestack-csi
ci/rehearse/openshift/csi-operator/master/e2e-azure-csi b9438cd link unknown /pj-rehearse pull-ci-openshift-csi-operator-master-e2e-azure-csi
ci/rehearse/openshift/csi-operator/master/e2e-azure-csi-extended b9438cd link unknown /pj-rehearse pull-ci-openshift-csi-operator-master-e2e-azure-csi-extended
ci/rehearse/openshift/csi-operator/master/e2e-azure-file-nfs-csi b9438cd link unknown /pj-rehearse pull-ci-openshift-csi-operator-master-e2e-azure-file-nfs-csi
ci/rehearse/openshift/csi-operator/master/e2e-azure-file-csi-extended b9438cd link unknown /pj-rehearse pull-ci-openshift-csi-operator-master-e2e-azure-file-csi-extended
ci/rehearse/openshift/azure-disk-csi-driver-operator/release-4.10/e2e-azure-csi b9438cd link unknown /pj-rehearse pull-ci-openshift-azure-disk-csi-driver-operator-release-4.10-e2e-azure-csi
ci/rehearse/openshift/azure-disk-csi-driver-operator/release-4.11/e2e-azurestack-csi b9438cd link unknown /pj-rehearse pull-ci-openshift-azure-disk-csi-driver-operator-release-4.11-e2e-azurestack-csi
ci/rehearse/openshift/azure-disk-csi-driver-operator/release-4.12/e2e-azurestack-csi b9438cd link unknown /pj-rehearse pull-ci-openshift-azure-disk-csi-driver-operator-release-4.12-e2e-azurestack-csi
ci/rehearse/openshift/origin/release-4.17/e2e-aws-csi b9438cd link unknown /pj-rehearse pull-ci-openshift-origin-release-4.17-e2e-aws-csi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dobsonj
Copy link
Member Author

dobsonj commented Mar 12, 2024

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 12, 2024
@dobsonj
Copy link
Member Author

dobsonj commented Mar 12, 2024

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 12, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 37771e9 into openshift:master Mar 12, 2024
32 of 47 checks passed
@openshift-ci-robot
Copy link
Contributor

@dobsonj: Jira Issue OCPBUGS-30620: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-30620 has not been moved to the MODIFIED state.

In response to this:

This updates the step-registry to use test manifests from the top-level directory of csi-operator, and builds the test images from a common Dockerfile.test. The intent is to eventually remove the legacy directory in this repo.

/hold
for openshift/csi-operator#194

/cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

memodi pushed a commit to memodi/release that referenced this pull request Mar 14, 2024
…t#49655)

* csi-operator: use test manifests from top-level directory

* csi-operator: build test images from common Dockerfile.test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
3 participants