Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.15] OCPBUGS-30621: move test manifest to top-level directory #195

Merged

Conversation

dobsonj
Copy link
Member

@dobsonj dobsonj commented Mar 7, 2024

This is sort of a backport of #194 to 4.15 where aws-ebs is built (before azure-disk and azure-file were added). The intent is to eventually remove the legacy directory, which means we have to move the manifests first.

It also creates Dockerfile.test which already exists in the master branch but not 4.15.

$ cp legacy/aws-ebs-csi-driver-operator/test/e2e/manifest.yaml test/e2e/aws-ebs/
$ cp Dockerfile.aws-ebs.test Dockerfile.test

Also remove the legacy test-unit and verify targets from the Makefile (we should be running these against the code we compile instead).

/cc @openshift/storage

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 7, 2024
@openshift-ci-robot
Copy link

@dobsonj: This pull request explicitly references no jira issue.

In response to this:

This is sort of a backport of #194 to 4.15 where aws-ebs is built (before azure-disk and azure-file were added). The intent is to eventually remove the legacy directory, which means we have to move the manifests first.

It also creates Dockerfile.test which already exists in the master branch but not 4.15.

$ cp legacy/aws-ebs-csi-driver-operator/test/e2e/manifest.yaml test/e2e/aws-ebs/
$ cp Dockerfile.aws-ebs.test Dockerfile.test

/cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Mar 7, 2024

@dobsonj: GitHub didn't allow me to request PR reviews from the following users: openshift/storage.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

This is sort of a backport of #194 to 4.15 where aws-ebs is built (before azure-disk and azure-file were added). The intent is to eventually remove the legacy directory, which means we have to move the manifests first.

It also creates Dockerfile.test which already exists in the master branch but not 4.15.

$ cp legacy/aws-ebs-csi-driver-operator/test/e2e/manifest.yaml test/e2e/aws-ebs/
$ cp Dockerfile.aws-ebs.test Dockerfile.test

/cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

openshift-ci bot commented Mar 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dobsonj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2024
@dobsonj
Copy link
Member Author

dobsonj commented Mar 8, 2024

/retest-required

Copy link
Contributor

openshift-ci bot commented Mar 8, 2024

@dobsonj: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jsafrane
Copy link
Contributor

jsafrane commented Mar 8, 2024

/jira cherrypick OCPBUGS-30620

@jsafrane
Copy link
Contributor

jsafrane commented Mar 8, 2024

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Mar 8, 2024
@openshift-ci-robot
Copy link

@jsafrane: Jira Issue OCPBUGS-30620 has been cloned as Jira Issue OCPBUGS-30621. Will retitle bug to link to clone.
/retitle OCPBUGS-30621: NO-JIRA: move test manifest to top-level directory

In response to this:

/jira cherrypick OCPBUGS-30620

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title NO-JIRA: move test manifest to top-level directory OCPBUGS-30621: NO-JIRA: move test manifest to top-level directory Mar 8, 2024
@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Mar 8, 2024
@openshift-ci-robot
Copy link

@dobsonj: This pull request references Jira Issue OCPBUGS-30621, which is invalid:

  • expected dependent Jira Issue OCPBUGS-30620 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is sort of a backport of #194 to 4.15 where aws-ebs is built (before azure-disk and azure-file were added). The intent is to eventually remove the legacy directory, which means we have to move the manifests first.

It also creates Dockerfile.test which already exists in the master branch but not 4.15.

$ cp legacy/aws-ebs-csi-driver-operator/test/e2e/manifest.yaml test/e2e/aws-ebs/
$ cp Dockerfile.aws-ebs.test Dockerfile.test

Also remove the legacy test-unit and verify targets from the Makefile (we should be running these against the code we compile instead).

/cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jsafrane jsafrane changed the title OCPBUGS-30621: NO-JIRA: move test manifest to top-level directory OCPBUGS-30621: move test manifest to top-level directory Mar 8, 2024
@duanwei33
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 12, 2024
@dobsonj dobsonj changed the title OCPBUGS-30621: move test manifest to top-level directory [4.15] OCPBUGS-30621: move test manifest to top-level directory Mar 12, 2024
@dobsonj
Copy link
Member Author

dobsonj commented Mar 13, 2024

/jira refresh

@openshift-ci-robot
Copy link

@dobsonj: This pull request references Jira Issue OCPBUGS-30621, which is invalid:

  • expected dependent Jira Issue OCPBUGS-30620 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dobsonj
Copy link
Member Author

dobsonj commented Mar 22, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 22, 2024
@openshift-ci-robot
Copy link

@dobsonj: This pull request references Jira Issue OCPBUGS-30621, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.z) matches configured target version for branch (4.15.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-30620 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-30620 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jsafrane
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit dad367b into openshift:release-4.15 Mar 27, 2024
9 checks passed
@openshift-ci-robot
Copy link

@dobsonj: Jira Issue OCPBUGS-30621: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-30621 has not been moved to the MODIFIED state.

In response to this:

This is sort of a backport of #194 to 4.15 where aws-ebs is built (before azure-disk and azure-file were added). The intent is to eventually remove the legacy directory, which means we have to move the manifests first.

It also creates Dockerfile.test which already exists in the master branch but not 4.15.

$ cp legacy/aws-ebs-csi-driver-operator/test/e2e/manifest.yaml test/e2e/aws-ebs/
$ cp Dockerfile.aws-ebs.test Dockerfile.test

Also remove the legacy test-unit and verify targets from the Makefile (we should be running these against the code we compile instead).

/cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-aws-ebs-csi-driver-operator-container-v4.15.0-202403271311.p0.gdad367b.assembly.stream.el9 for distgit ose-aws-ebs-csi-driver-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants