-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSASINFRA-3618: Add Cinder CSI support (part 2) #275
OSASINFRA-3618: Add Cinder CSI support (part 2) #275
Conversation
Skipping CI for Draft Pull Request. |
Did you check https://github.com/openshift/enhancements/blob/master/enhancements/storage/csi-driver-operator-merge.md for steps about how to merge operators? Specifically the exact steps should be documented here - https://github.com/openshift/enhancements/blob/master/enhancements/storage/csi-driver-operator-merge.md#process-of-moving-operators-to-csi-operator-monorepo But do let us know if we missed anything. It will be helpful. |
d0520a2
to
64ffc6f
Compare
/retitle OSASINFRA-3618: Add Cinder CSI support (part 2) |
@stephenfin: This pull request references OSASINFRA-3618 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@stephenfin: This pull request references OSASINFRA-3618 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
64ffc6f
to
bf809d7
Compare
@stephenfin: This pull request references OSASINFRA-3618 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@stephenfin: This pull request references OSASINFRA-3618 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@stephenfin: This pull request references OSASINFRA-3618 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@stephenfin: This pull request references OSASINFRA-3618 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
bf809d7
to
e33163b
Compare
The location of files have changed [1]. Reflect this. [1] openshift/csi-operator#275 Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
This was removed in [1]. [1] openshift/csi-operator#275 Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Done. I'd forgotten to initialise an informer for the relevant namespace. EDIT: ...and create the ClusterRoleBinding, since our controller currently needs to be privileged (due to use of host networking). |
e33163b
to
c32431e
Compare
@gnufied I have an ask: assuming there is nothing too egregious here, would you be okay with me addressing the comments here in a follow-up PR? EDIT: In anticipation, I have proposed #292. It currently contains resolution to most of the comments here and I can address the remaining ones as necessary. Assuming this is okay, I'll rebase #292 once this merges. EDIT 2: I've merged #292 back into this change after all. |
Trivial nit. Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
This won't appear in the generated assets, but that's okay: this is most relevant to OpenShift devs. Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gnufied, stephenfin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@stephenfin: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/retest-required |
/label px-approved |
e9b462f
into
openshift:master
The location of files have changed [1]. Reflect this. [1] openshift/csi-operator#275 Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
[ART PR BUILD NOTIFIER] Distgit: azure-file-csi-driver-operator |
[ART PR BUILD NOTIFIER] Distgit: ose-aws-efs-csi-driver-operator |
[ART PR BUILD NOTIFIER] Distgit: csi-driver-manila-operator |
[ART PR BUILD NOTIFIER] Distgit: ose-azure-disk-csi-driver-operator |
[ART PR BUILD NOTIFIER] Distgit: ose-aws-ebs-csi-driver-operator |
[ART PR BUILD NOTIFIER] Distgit: ose-smb-csi-driver-operator |
[ART PR BUILD NOTIFIER] Distgit: ose-openstack-cinder-csi-driver-operator |
The location of files have changed [1]. Reflect this. [1] openshift/csi-operator#275 Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
…ift#57034) The location of files have changed [1]. Reflect this. [1] openshift/csi-operator#275 Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
…ift#57034) The location of files have changed [1]. Reflect this. [1] openshift/csi-operator#275 Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
This is part 2 of the process of merging the OpenStack Cinder CSI Driver operator into
csi-operator
.This PR addresses the fourth step in the migration guide, namely moving the operator to the new structure in
csi-operator
.Follow-up PRs will remove the
legacy/openstack-cinder-csi-driver-operator
directory and update both the CI jobs and image builds to remove references to same.You can compare the assets generated here using the following script, which relies on difftastic (available from the Fedora repos):
Previous steps: