OSASINFRA-3618: Add Cinder CSI support (part 2)

[stephenfin]

This is part 2 of the process of merging the OpenStack Cinder CSI Driver operator into csi-operator.

This PR addresses the fourth step in the migration guide, namely moving the operator to the new structure in csi-operator.

Follow-up PRs will remove the legacy/openstack-cinder-csi-driver-operator directory and update both the CI jobs and image builds to remove references to same.

You can compare the assets generated here using the following script, which relies on difftastic (available from the Fedora repos):

#!/usr/bin/env python3

import pathlib
import subprocess
import sys


assets = [
    p
    for p in pathlib.Path('openstack-cinder-csi-driver-operator/assets').glob(
        '*.yaml'
    )
]
assets += [
    p
    for p in pathlib.Path('openstack-cinder-csi-driver-operator/assets/rbac').glob('*.yaml')
]

csi_operator_assets = pathlib.Path(
    'csi-operator/assets/overlays/openstack-cinder/generated/standalone/'
)
for legacy_asset in assets:
    # map assets with different names
    asset_name = {
        'prometheus_rolebinding.yaml': 'prometheus_binding.yaml',
        'lease_leader_election_rolebinding.yaml': 'lease_leader_election_binding.yaml',
    }.get(legacy_asset.name, legacy_asset.name)
    csi_operator_asset = csi_operator_assets / legacy_asset.name
    if not csi_operator_asset.exists():
        print(f'ERROR: {csi_operator_asset} does not exist!')
        sys.exit(1)

    subprocess.run(
        f'difft --ignore-comments {legacy_asset} {csi_operator_asset}',
        shell=True,
    )

Previous steps:

• OSASINFRA-3609: Add Cinder CSI support (part 1) #278
• OSASINFRA-3609: Update legacy/openstack-cinder-csi-driver-operator #281
• OSASINFRA-3609: Use csi-operator for building openstack-cinder CSI driver release#56812
• OSASINFRA-3609: Move OpenStack Cinder CSI Driver Operator to csi-operator repo openshift-eng/ocp-build-data#5402
• OSASINFRA-3609: Mark the repository as obsolete openstack-cinder-csi-driver-operator#180

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[gnufied]

Did you check https://github.com/openshift/enhancements/blob/master/enhancements/storage/csi-driver-operator-merge.md for steps about how to merge operators?

Specifically the exact steps should be documented here - https://github.com/openshift/enhancements/blob/master/enhancements/storage/csi-driver-operator-merge.md#process-of-moving-operators-to-csi-operator-monorepo

But do let us know if we missed anything. It will be helpful.

[stephenfin]

/retitle OSASINFRA-3618: Add Cinder CSI support (part 2)

[openshift-ci-robot]

@stephenfin: This pull request references OSASINFRA-3618 which is a valid jira issue.

In response to this:

This is work in progress as I still need to test this and iron out the last few kinks. I am trying to structure it such that it will be helpful HOWTO for others though.

Previous steps:

• OSASINFRA-3609: Add Cinder CSI support (part 1) #278

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@stephenfin: This pull request references OSASINFRA-3618 which is a valid jira issue.

In response to this:

This is part 2 of the process of merging the OpenStack Cinder CSI Driver operator into csi-operator.

This PR address the fourth step in the migration guide, namely moving the operator to the new structure in csi-operator.

Follow-up PRs will remove the legacy/openstack-cinder-csi-driver-operator directory and both the CI jobs and image builds to remove references to same.

Commits:

• TODO

Previous steps:

• OSASINFRA-3609: Add Cinder CSI support (part 1) #278
• OSASINFRA-3609: Update legacy/openstack-cinder-csi-driver-operator #281
• OSASINFRA-3609: Use csi-operator for building openstack-cinder CSI driver release#56812
• OSASINFRA-3609: Move OpenStack Cinder CSI Driver Operator to csi-operator repo openshift-eng/ocp-build-data#5402
• OSASINFRA-3609: Mark the repository as obsolete openstack-cinder-csi-driver-operator#180

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@stephenfin: This pull request references OSASINFRA-3618 which is a valid jira issue.

In response to this:

This is part 2 of the process of merging the OpenStack Cinder CSI Driver operator into csi-operator.

This PR address the fourth step in the migration guide, namely moving the operator to the new structure in csi-operator.

Follow-up PRs will remove the legacy/openstack-cinder-csi-driver-operator directory and both the CI jobs and image builds to remove references to same.

Previous steps:

• OSASINFRA-3609: Add Cinder CSI support (part 1) #278
• OSASINFRA-3609: Update legacy/openstack-cinder-csi-driver-operator #281
• OSASINFRA-3609: Use csi-operator for building openstack-cinder CSI driver release#56812
• OSASINFRA-3609: Move OpenStack Cinder CSI Driver Operator to csi-operator repo openshift-eng/ocp-build-data#5402
• OSASINFRA-3609: Mark the repository as obsolete openstack-cinder-csi-driver-operator#180

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@stephenfin: This pull request references OSASINFRA-3618 which is a valid jira issue.

In response to this:

This is part 2 of the process of merging the OpenStack Cinder CSI Driver operator into csi-operator.

This PR address the fourth step in the migration guide, namely moving the operator to the new structure in csi-operator.

Follow-up PRs will remove the legacy/openstack-cinder-csi-driver-operator directory and both the CI jobs and image builds to remove references to same.

Previous steps:

• OSASINFRA-3609: Add Cinder CSI support (part 1) #278
• OSASINFRA-3609: Update legacy/openstack-cinder-csi-driver-operator #281
• OSASINFRA-3609: Use csi-operator for building openstack-cinder CSI driver release#56812
• OSASINFRA-3609: Move OpenStack Cinder CSI Driver Operator to csi-operator repo openshift-eng/ocp-build-data#5402
• OSASINFRA-3609: Mark the repository as obsolete openstack-cinder-csi-driver-operator#180

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@stephenfin: This pull request references OSASINFRA-3618 which is a valid jira issue.

In response to this:

This is part 2 of the process of merging the OpenStack Cinder CSI Driver operator into csi-operator.

This PR address the fourth step in the migration guide, namely moving the operator to the new structure in csi-operator.

Follow-up PRs will remove the legacy/openstack-cinder-csi-driver-operator directory and both the CI jobs and image builds to remove references to same.

Previous steps:

• OSASINFRA-3609: Add Cinder CSI support (part 1) #278
• OSASINFRA-3609: Update legacy/openstack-cinder-csi-driver-operator #281
• OSASINFRA-3609: Use csi-operator for building openstack-cinder CSI driver release#56812
• OSASINFRA-3609: Move OpenStack Cinder CSI Driver Operator to csi-operator repo openshift-eng/ocp-build-data#5402
• OSASINFRA-3609: Mark the repository as obsolete openstack-cinder-csi-driver-operator#180

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@stephenfin: This pull request references OSASINFRA-3618 which is a valid jira issue.

In response to this:

This is part 2 of the process of merging the OpenStack Cinder CSI Driver operator into csi-operator.

This PR address the fourth step in the migration guide, namely moving the operator to the new structure in csi-operator.

Follow-up PRs will remove the legacy/openstack-cinder-csi-driver-operator directory and update both the CI jobs and image builds to remove references to same.

Previous steps:

• OSASINFRA-3609: Add Cinder CSI support (part 1) #278
• OSASINFRA-3609: Update legacy/openstack-cinder-csi-driver-operator #281
• OSASINFRA-3609: Use csi-operator for building openstack-cinder CSI driver release#56812
• OSASINFRA-3609: Move OpenStack Cinder CSI Driver Operator to csi-operator repo openshift-eng/ocp-build-data#5402
• OSASINFRA-3609: Mark the repository as obsolete openstack-cinder-csi-driver-operator#180

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[stephenfin]

Failures look real. I'm investigating.

Done. I'd forgotten to initialise an informer for the relevant namespace.

EDIT: ...and create the ClusterRoleBinding, since our controller currently needs to be privileged (due to use of host networking).

[stephenfin]

@gnufied I have an ask: assuming there is nothing too egregious here, would you be okay with me addressing the comments here in a follow-up PR?

EDIT: In anticipation, I have proposed #292. It currently contains resolution to most of the comments here and I can address the remaining ones as necessary. Assuming this is okay, I'll rebase #292 once this merges.

EDIT 2: I've merged #292 back into this change after all.

[gnufied]

/retest
/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied, stephenfin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [gnufied]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@stephenfin: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/security	fcac8f2	link	false	/test security
ci/prow/e2e-azurestack-csi	fcac8f2	link	false	/test e2e-azurestack-csi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[stephenfin]

/retest-required

[gnufied]

/label px-approved
/label docs-approved

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: azure-file-csi-driver-operator
This PR has been included in build ose-azure-file-csi-driver-operator-container-v4.18.0-202410142041.p0.ge9b462f.assembly.stream.el9.
All builds following this will include this PR.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: ose-aws-efs-csi-driver-operator
This PR has been included in build ose-aws-efs-csi-driver-operator-container-v4.18.0-202410142041.p0.ge9b462f.assembly.stream.el9.
All builds following this will include this PR.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: csi-driver-manila-operator
This PR has been included in build csi-driver-manila-operator-container-v4.18.0-202410142041.p0.ge9b462f.assembly.stream.el9.
All builds following this will include this PR.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: ose-azure-disk-csi-driver-operator
This PR has been included in build ose-azure-disk-csi-driver-operator-container-v4.18.0-202410142041.p0.ge9b462f.assembly.stream.el9.
All builds following this will include this PR.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: ose-aws-ebs-csi-driver-operator
This PR has been included in build ose-aws-ebs-csi-driver-operator-container-v4.18.0-202410142041.p0.ge9b462f.assembly.stream.el9.
All builds following this will include this PR.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: ose-smb-csi-driver-operator
This PR has been included in build ose-smb-csi-driver-operator-container-v4.18.0-202410142041.p0.ge9b462f.assembly.stream.el9.
All builds following this will include this PR.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: ose-openstack-cinder-csi-driver-operator
This PR has been included in build ose-openstack-cinder-csi-driver-operator-container-v4.18.0-202410142041.p0.ge9b462f.assembly.stream.el9.
All builds following this will include this PR.