-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HAC-2169] Details page component (header + horizontal nav) #164
[HAC-2169] Details page component (header + horizontal nav) #164
Conversation
action menu working actions menu page header update tests updated index.ts
Option to have action menu icon after text
update
Codecov ReportBase: 17.74% // Head: 22.31% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #164 +/- ##
==========================================
+ Coverage 17.74% 22.31% +4.56%
==========================================
Files 44 59 +15
Lines 1544 1788 +244
Branches 413 466 +53
==========================================
+ Hits 274 399 +125
- Misses 1270 1388 +118
- Partials 0 1 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
FWIW this diff is much smaller when merged with upstream now, though Github is still showing the entire diff on this PR. |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: florkbr, vidyanambiar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@vidyanambiar: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Note: This PR depends on PR #156
Jira ticket: https://issues.redhat.com/browse/HAC-2169
Test with
yarn storybook
.This PR combines the details page header component and the horizontal nav to create a details page component.