Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HAC-2169] Details page component (header + horizontal nav) #164

Merged
merged 5 commits into from
Oct 6, 2022

Conversation

vidyanambiar
Copy link
Contributor

Note: This PR depends on PR #156

Jira ticket: https://issues.redhat.com/browse/HAC-2169

Test with yarn storybook.

This PR combines the details page header component and the horizontal nav to create a details page component.

image

@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2022

Codecov Report

Base: 17.74% // Head: 22.31% // Increases project coverage by +4.56% 🎉

Coverage data is based on head (ae13875) compared to base (7dba4fb).
Patch coverage: 53.66% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #164      +/-   ##
==========================================
+ Coverage   17.74%   22.31%   +4.56%     
==========================================
  Files          44       59      +15     
  Lines        1544     1788     +244     
  Branches      413      466      +53     
==========================================
+ Hits          274      399     +125     
- Misses       1270     1388     +118     
- Partials        0        1       +1     
Impacted Files Coverage Δ
.../details-page-header/DetailsPageHeader.stories.tsx 0.00% <0.00%> (ø)
...-utils/src/components/details-page-header/index.ts 0.00% <0.00%> (ø)
...etails-page-header/utils/ActionButtons.stories.tsx 0.00% <0.00%> (ø)
...s/details-page-header/utils/ActionMenu.stories.tsx 0.00% <0.00%> (ø)
.../details-page-header/utils/Breadcrumbs.stories.tsx 0.00% <0.00%> (ø)
...rc/components/details-page/DetailsPage.stories.tsx 0.00% <0.00%> (ø)
...-utils/src/components/details-page/DetailsPage.tsx 0.00% <0.00%> (ø)
...s/lib-utils/src/components/horizontal-nav/index.ts 0.00% <0.00%> (ø)
...ls/src/components/horizontal-nav/HorizontalNav.tsx 93.33% <71.42%> (-6.67%) ⬇️
...mponents/details-page-header/DetailsPageHeader.tsx 80.00% <80.00%> (ø)
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@florkbr
Copy link
Contributor

florkbr commented Oct 6, 2022

FWIW this diff is much smaller when merged with upstream now, though Github is still showing the entire diff on this PR.

image

https://github.com/openshift/dynamic-plugin-sdk/compare/main...florkbr:dynamic-plugin-sdk:details-page?diff=unified

@florkbr
Copy link
Contributor

florkbr commented Oct 6, 2022

/lgtm

@florkbr
Copy link
Contributor

florkbr commented Oct 6, 2022

/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 6, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: florkbr, vidyanambiar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 6, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 6, 2022

@vidyanambiar: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 4f66a7b into openshift:main Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants