Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-14947: Fix hostmount propagation #424

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

Vincent056
Copy link
Contributor

@Vincent056 Vincent056 commented Aug 9, 2023

This PR fixes issues on CSI driver relying on multipath, we need to set MountPropagation to HostToContainer to address this issue.

OCPBUGS-14947

This PR fixes issues on CSI driver relying on multipath, we need to set MountPropagation to HostToContainer to address this issue.
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Aug 9, 2023
@openshift-ci-robot
Copy link

@Vincent056: This pull request references Jira Issue OCPBUGS-14947, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This PR fixes issues on CSI driver relying on multipath, we need to set MountPropagation to HostToContainer to address this issue.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Aug 9, 2023
@openshift-ci openshift-ci bot requested review from rhmdnd and xiaojiey August 9, 2023 05:29
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2023
@openshift-ci-robot
Copy link

@Vincent056: This pull request references Jira Issue OCPBUGS-14947, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

This PR fixes issues on CSI driver relying on multipath, we need to set MountPropagation to HostToContainer to address this issue.

OCPBUGS-14947

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 9, 2023

@Vincent056: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@rhmdnd rhmdnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 9, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhmdnd, Vincent056

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xiaojiey
Copy link

Verification pass with 4.14.0-0.nightly-2023-08-10-072041 + Code in the PR:
Per https://access.redhat.com/solutions/7017081, verified daemon container of aide pods have now the HostToContainer mount propagation.

$ oc apply -f -<<EOF
apiVersion: fileintegrity.openshift.io/v1alpha1
kind: FileIntegrity
metadata:
  name: example-fileintegrity
spec:
  config:
    gracePeriod: 300
    maxBackups: 5
  debug: true
EOF
fileintegrity.fileintegrity.openshift.io/example-fileintegrity created
$ oc get pod
NAME                                       READY   STATUS    RESTARTS      AGE
aide-example-fileintegrity-6n45r           1/1     Running   0             3m30s
aide-example-fileintegrity-8r7qt           1/1     Running   0             3m30s
aide-example-fileintegrity-b92d6           1/1     Running   0             3m30s
aide-example-fileintegrity-jj598           1/1     Running   0             3m30s
aide-example-fileintegrity-ntkmf           1/1     Running   0             3m30s
aide-example-fileintegrity-zqlgc           1/1     Running   0             3m30s
file-integrity-operator-6b67d89b67-nk6dr   1/1     Running   1 (91m ago)   91m
$ oc get pod -l file-integrity.openshift.io/pod= '-o=jsonpath={.items[*].spec.containers[?(@.name=="daemon")].volumeMounts[0]}' | jq -r
{
  "mountPath": "/hostroot",
  "mountPropagation": "HostToContainer",
  "name": "hostroot"
}
{
  "mountPath": "/hostroot",
  "mountPropagation": "HostToContainer",
  "name": "hostroot"
}
{
  "mountPath": "/hostroot",
  "mountPropagation": "HostToContainer",
  "name": "hostroot"
}
{
  "mountPath": "/hostroot",
  "mountPropagation": "HostToContainer",
  "name": "hostroot"
}
{
  "mountPath": "/hostroot",
  "mountPropagation": "HostToContainer",
  "name": "hostroot"
}
{
  "mountPath": "/hostroot",
  "mountPropagation": "HostToContainer",
  "name": "hostroot"
}

@xiaojiey
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Aug 11, 2023
@Vincent056
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link

@Vincent056: This pull request references Jira Issue OCPBUGS-14947, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xiaojiey
Copy link

/jira refresh

@openshift-ci-robot
Copy link

@xiaojiey: This pull request references Jira Issue OCPBUGS-14947, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xiaojiey
Copy link

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 14, 2023
@openshift-ci-robot
Copy link

@xiaojiey: This pull request references Jira Issue OCPBUGS-14947, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 97981b4 into openshift:master Aug 14, 2023
@openshift-ci-robot
Copy link

@Vincent056: Jira Issue OCPBUGS-14947: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-14947 has been moved to the MODIFIED state.

In response to this:

This PR fixes issues on CSI driver relying on multipath, we need to set MountPropagation to HostToContainer to address this issue.

OCPBUGS-14947

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants