Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate application name on submit #159

Merged
merged 1 commit into from
Aug 4, 2022

Conversation

rohitkrai03
Copy link
Contributor

Fixes

Description

  • The application name was being validated onBlur which is why on first click it would validate and enable the next button. On next click it would change the step.
  • Updated the validation to validate on submit instead of onBlur.

Type of change

  • Feature
  • Bugfix

Screen shots / Gifs for design review

Screen.Recording.2022-07-28.at.6.10.32.PM.mov

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 28, 2022

@rohitkrai03: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@codecov
Copy link

codecov bot commented Jul 28, 2022

Codecov Report

Merging #159 (e7a4321) into main (dcaca37) will increase coverage by 0.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #159      +/-   ##
==========================================
+ Coverage   62.08%   62.22%   +0.13%     
==========================================
  Files         243      243              
  Lines        4671     4675       +4     
  Branches     1113     1114       +1     
==========================================
+ Hits         2900     2909       +9     
+ Misses       1678     1673       -5     
  Partials       93       93              
Impacted Files Coverage Δ
...rc/components/ImportForm/utils/validation-utils.ts 100.00% <ø> (+31.25%) ⬆️
src/components/ImportForm/utils/submit-utils.ts 100.00% <100.00%> (ø)
src/components/ImportForm/utils/useImportSteps.tsx 81.81% <100.00%> (+0.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcaca37...e7a4321. Read the comment docs.

Copy link
Contributor

@sahil143 sahil143 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 1, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 1, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rohitkrai03, sahil143

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2022
@rohitkrai03
Copy link
Contributor Author

/retest

2 similar comments
@rohitkrai03
Copy link
Contributor Author

/retest

@rohitkrai03
Copy link
Contributor Author

/retest

@rohitkrai03
Copy link
Contributor Author

CI passing locally on this branch.
Screenshot 2022-08-04 at 5 35 27 PM

@rohitkrai03 rohitkrai03 merged commit 2c16f55 into openshift:main Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants