-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate application name on submit #159
Conversation
@rohitkrai03: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Codecov Report
@@ Coverage Diff @@
## main #159 +/- ##
==========================================
+ Coverage 62.08% 62.22% +0.13%
==========================================
Files 243 243
Lines 4671 4675 +4
Branches 1113 1114 +1
==========================================
+ Hits 2900 2909 +9
+ Misses 1678 1673 -5
Partials 93 93
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rohitkrai03, sahil143 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
2 similar comments
/retest |
/retest |
Fixes
Description
Type of change
Screen shots / Gifs for design review
Screen.Recording.2022-07-28.at.6.10.32.PM.mov
Browser conformance: