Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pipelinerun & taskrun status #226

Merged

Conversation

abhinandan13jan
Copy link
Contributor

@abhinandan13jan abhinandan13jan commented Sep 23, 2022

Fixes

https://issues.redhat.com/browse/HACBS-1176
https://issues.redhat.com/browse/HACBS-1177

Description

Adds Status icon to

  1. PLR details header
  2. PLR list
  3. TaskRun List

Type of change

  • Feature
  • Bugfix
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Screen shots / Gifs for design review

Screenshot 2022-09-26 at 8 51 00 PM

Screenshot 2022-09-26 at 8 51 11 PM

Screenshot 2022-09-23 at 5 13 04 PM

Screenshot 2022-09-23 at 5 15 24 PM

How to test or reproduce?

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 23, 2022

@abhinandan13jan: The label(s) /label hacbs cannot be applied. These labels are supported: platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, downstream-change-needed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, staff-eng-approved

In response to this:

/label hacbs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Sep 23, 2022

Codecov Report

Merging #226 (a2ebb82) into main (f1ac17f) will increase coverage by 0.75%.
The diff coverage is 92.85%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #226      +/-   ##
==========================================
+ Coverage   70.18%   70.93%   +0.75%     
==========================================
  Files         379      380       +1     
  Lines        7496     7817     +321     
  Branches     1858     1974     +116     
==========================================
+ Hits         5261     5545     +284     
- Misses       2114     2141      +27     
- Partials      121      131      +10     
Impacted Files Coverage Δ
...ponents/PipelineRunListView/PipelineRunListRow.tsx 46.15% <66.66%> (+4.48%) ⬆️
.../PipelineRunDetailsView/PipelineRunDetailsView.tsx 100.00% <100.00%> (ø)
...elineRunDetailsView/tabs/PipelineRunDetailsTab.tsx 94.44% <100.00%> (+0.32%) ⬆️
...acbs/components/TaskRunListView/TaskRunListRow.tsx 100.00% <100.00%> (ø)
...shared/components/pipeline-run-logs/StatusIcon.tsx 54.28% <100.00%> (+8.33%) ⬆️
...ionEnvironment/ApplicationEnvironmentGraphView.tsx 72.46% <0.00%> (-4.10%) ⬇️
.../shared/components/formik-fields/TextAreaField.tsx 83.78% <0.00%> (-3.72%) ⬇️
...ponents/ImportForm/ReviewSection/ReviewSection.tsx 25.33% <0.00%> (-2.45%) ⬇️
...nEnvironment/ApplicationEnvironmentDetailsView.tsx 88.97% <0.00%> (-0.31%) ⬇️
...ponents/ImportForm/SampleSection/SampleSection.tsx 94.73% <0.00%> (-0.10%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1ac17f...a2ebb82. Read the comment docs.

@christianvogt
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 26, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinandan13jan, christianvogt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2022
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2022
@karthikjeeyar
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2022
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 7, 2022
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2022
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 7, 2022
@karthikjeeyar
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2022
@abhinandan13jan
Copy link
Contributor Author

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 10, 2022

@abhinandan13jan: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 163a1cd into openshift:main Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. hacbs lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants