Fixing golangci-lint cache permission issue

[LalatenduMohanty]

It seems like an issue when go code running in container as non-root user, and the user does not exist in the container. Go by default disables the cache. It seems we will need to set GOCACHE explicitly when running a build as a nonexistent user (in our case it is root I think) [1] . Not sure what user ID we are expected to use in the CI system.

As per [2] $XDG_CACHE_HOME defines the base directory relative to which user specific non-essential data files should be stored. If $XDG_CACHE_HOME is either not set or empty, a default equal to $HOME/.cache should be used.

The idea is to set it to a location where the go program (in this case golangci-lint) have write access.

[1] golang/go#26280
[2] https://specifications.freedesktop.org/basedir-spec/0.6/ar01s03.html

Signed-off-by: Lalatendu Mohanty lmohanty@redhat.com

[LalatenduMohanty]

/hold
Will do few reruns to make sure it works

[dgoodwin]

Could you clarify what this env var is and why it fixes the problem in commit message.

[LalatenduMohanty]

Could you clarify what this env var is and why it fixes the problem in commit messag

Will do.
It seems like an issue when go code running in container as non-root user, and the user does not exist in the container. Go by default disables the cache. It seems we will need to set GOCACHE explicitly when running a build as a nonexistent user (in our case it is root I think) [1] . Not sure what user ID we are expected to use in the CI system.

As per [2] $XDG_CACHE_HOME defines the base directory relative to which user specific non-essential data files should be stored. If $XDG_CACHE_HOME is either not set or empty, a default equal to $HOME/.cache should be used.

The idea is to set it to a location where the go program (in this case golangci-lint) have write access.

[1] golang/go#26280
[2] https://specifications.freedesktop.org/basedir-spec/0.6/ar01s03.html

[LalatenduMohanty]

/test unit

[LalatenduMohanty]

/hold cancel

[LalatenduMohanty]

/test unit

[dgoodwin]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin, LalatenduMohanty

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [LalatenduMohanty,dgoodwin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[staebler]

Remove this line.

[staebler]

Oops. I forgot to submit my review changes. :)

[staebler]

#570

[nitin-wise]

Could you clarify what this env var is and why it fixes the problem in commit messag

Will do.
It seems like an issue when go code running in container as non-root user, and the user does not exist in the container. Go by default disables the cache. It seems we will need to set GOCACHE explicitly when running a build as a nonexistent user (in our case it is root I think) [1] . Not sure what user ID we are expected to use in the CI system.

As per [2] $XDG_CACHE_HOME defines the base directory relative to which user specific non-essential data files should be stored. If $XDG_CACHE_HOME is either not set or empty, a default equal to $HOME/.cache should be used.

The idea is to set it to a location where the go program (in this case golangci-lint) have write access.

[1] golang/go#26280
[2] https://specifications.freedesktop.org/basedir-spec/0.6/ar01s03.html

Worked when XDG_CACHE_HOME = './' to bring the cache home to code path