Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOSTEDCP-1838: Migrate buildah config in tekton files for migration from 0.1 to 0.2 #4403

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

bryan-cox
Copy link
Member

What this PR does / why we need it:
This PR:

Which issue(s) this PR fixes:
Fixes HOSTEDCP-1838

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

red-hat-konflux bot and others added 2 commits July 22, 2024 11:42
Signed-off-by: red-hat-konflux <123456+red-hat-konflux[bot]@users.noreply.github.com>
Removes BASE_IMAGES_DIGESTS per https://github
.com/konflux-ci/build-definitions/blob/main/task/buildah/0.2/MIGRATION.md

Signed-off-by: Bryan Cox <brcox@redhat.com>
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 22, 2024

@bryan-cox: This pull request references HOSTEDCP-1838 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.

In response to this:

What this PR does / why we need it:
This PR:

Which issue(s) this PR fixes:
Fixes HOSTEDCP-1838

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 22, 2024
Copy link
Contributor

openshift-ci bot commented Jul 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2024
@bryan-cox
Copy link
Member Author

/area ci-tooling

@openshift-ci openshift-ci bot added area/ci-tooling Indicates the PR includes changes for CI or tooling and removed do-not-merge/needs-area labels Jul 22, 2024
Copy link
Contributor

openshift-ci bot commented Jul 22, 2024

@bryan-cox: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@bryan-cox
Copy link
Member Author

/retest

@csrwng
Copy link
Contributor

csrwng commented Jul 22, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit b09d987 into openshift:main Jul 22, 2024
8 checks passed
@bryan-cox bryan-cox deleted the HOSTEDCP-1838 branch July 22, 2024 18:41
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: hypershift
This PR has been included in build ose-hypershift-container-v4.17.0-202407222110.p0.gb09d987.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ci-tooling Indicates the PR includes changes for CI or tooling jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants