Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1788112: override node selector (4.3) #63

Merged

Conversation

iNecas
Copy link
Contributor

@iNecas iNecas commented Jan 6, 2020

To ensure the deployment works properly in case of default node selector
is set.

(cherry picked from commit 53cfc74)

To ensure the deployment works properly in case of default node selector
is set.

(cherry picked from commit 53cfc74)
@openshift-ci-robot
Copy link
Contributor

@iNecas: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Bug 1788112 - override node selector (4.3)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 6, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2020
@iNecas iNecas changed the title Bug 1788112 - override node selector (4.3) Bug 1788112: override node selector (4.3) Jan 6, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 6, 2020
@openshift-ci-robot
Copy link
Contributor

@iNecas: This pull request references Bugzilla bug 1788112, which is invalid:

  • expected the bug to target the "4.3.0" release, but it targets "4.3.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1788112: override node selector (4.3)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@iNecas
Copy link
Contributor Author

iNecas commented Jan 6, 2020

/refresh bugzilla

@iNecas
Copy link
Contributor Author

iNecas commented Jan 7, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@iNecas: This pull request references Bugzilla bug 1788112, which is invalid:

  • expected the bug to target the "4.3.0" release, but it targets "4.3.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alexandrevicenzi
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 7, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexandrevicenzi, iNecas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [alexandrevicenzi,iNecas]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@alexandrevicenzi
Copy link
Contributor

@iNecas could you fix the BZ issue to pass tide?

@iNecas
Copy link
Contributor Author

iNecas commented Feb 10, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 10, 2020
@openshift-ci-robot
Copy link
Contributor

@iNecas: This pull request references Bugzilla bug 1788112, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 10, 2020
@mfojtik mfojtik added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 14, 2020
@openshift-merge-robot openshift-merge-robot merged commit 7d42f89 into openshift:release-4.3 Feb 14, 2020
@openshift-ci-robot
Copy link
Contributor

@iNecas: All pull requests linked via external trackers have merged. Bugzilla bug 1788112 has been moved to the MODIFIED state.

In response to this:

Bug 1788112: override node selector (4.3)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants