Add defaultNodeSelector annotation to openshift-etcd namespace #1689
Conversation
openshift-ci-robot
added
the
size/XS
|
/cc @abhinavdahiya @wking |
|
These pods are static, but there probably will be installer pods in there later. /lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, deads2k, ravisantoshgudimetla The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
abhinavdahiya
changed the title
ravisantoshgudimetla
changed the title
|
/retest |
1 similar comment
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Why this change?
When openshift/cluster-kube-apiserver-operator#394 merges, all the pods running openshift cluster will have a defaultNodeSelector if it has been set by cluster-admin including pods running in
openshift-*namespace. The main advantage of having that feature is in a multi-tenant environment, any new project created can be steered towards compute nodes(non-master nodes).What should I do?
If you think, the pods in your namespace shouldn't have defaultNodeSelector set, please review this PR. If not feel free to close this. The annotation added as part of this PR lets all the pods created within your project to not have the defaultNodeSelector set.
/cc @deads2k @sjenning
I see that there is also
openshift-machine-config-operatornamespace created here(https://github.com/openshift/installer/blob/master/data/data/manifests/bootkube/04-openshift-machine-config-operator.yaml) but I see that annotation is already applied to that namespace not sure which component is applying it.