cmd/openshift-install/gather: Recognize "connection refused" #2810
Conversation
openshift-ci-robot
added
the
size/S
wking
force-pushed
the
gather-ssh-recognize-connection-refused
branch
from
1589774
to
3733c59
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Before this commit, bootstrap machines that failed to come up would look like [1]: level=info msg="Waiting up to 30m0s for the Kubernetes API at https://api.ci-op-6266tp8r-77109.origin-ci-int-aws.dev.rhcloud.com:6443..." level=error msg="Attempted to gather ClusterOperator status after installation failure: listing ClusterOperator objects: Get https://api.ci-op-6266tp8r-77109.origin-ci-int-aws.dev.rhcloud.com:6443/apis/config.openshift.io/v1/clusteroperators: dial tcp 3.221.214.197:6443: connect: connection refused" level=info msg="Pulling debug logs from the bootstrap machine" level=error msg="Attempted to gather debug logs after installation failure: failed to create SSH client, ensure the proper ssh key is in your keyring or specify with --key: dial tcp 3.84.188.207:22: connect: connection refused" level=fatal msg="Bootstrap failed to complete: waiting for Kubernetes API: context deadline exceeded" With this commit, that last error will look like: level=error msg="Attempted to gather debug logs after installation failure: failed to connect to the bootstrap machine: dial tcp 3.84.188.207:22: connect: connection refused" without the unrelated (to this failure mode) distraction about SSH keys. [1]: https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/logs/release-openshift-origin-installer-e2e-aws-upgrade/12076
wking
force-pushed
the
gather-ssh-recognize-connection-refused
branch
from
3733c59
to
684d92c
Compare
| return errors.Wrap(err, "failed to create SSH client, ensure the proper ssh key is in your keyring or specify with --key") | ||
| } else if err != nil { | ||
| if err != nil { | ||
| if errno, ok := err.(syscall.Errno); ok && errno == syscall.ECONNREFUSED { |
There was a problem hiding this comment.
hmm.. shouldn't see https://golang.org/pkg/net/#OpError ? and the OpError.Err contains the syscall error?
There was a problem hiding this comment.
I'll just wait for Go 1.13 and the Unwrap business.
|
/uncc @jstuever |
openshift-ci-robot
added
the
needs-rebase
|
@wking: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@wking: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
abhinavdahiya
added
version/4.6
|
replaced by #3615 /close |
|
@abhinavdahiya: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Before this commit, bootstrap machines that failed to come up would look like:
With this commit, that last error will look like:
without the unrelated (to this failure mode) distraction about SSH keys.