OCPBUGS-20345: OCPBUGS-19092: Enable serial console for external OCI platform #7511
Conversation
openshift-ci-robot
added
jira/severity-low
|
@pawanpinjarkar: This pull request references Jira Issue OCPBUGS-19092, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
jira/valid-bug
pawanpinjarkar
changed the title
pawanpinjarkar
force-pushed
the
enable-console-on-oci
branch
3 times, most recently
from
944a3bc
to
cae4021
Compare
pawanpinjarkar
force-pushed
the
enable-console-on-oci
branch
from
cae4021
to
c17986c
Compare
|
/retest-required |
pawanpinjarkar
force-pushed
the
enable-console-on-oci
branch
from
c17986c
to
7c13bfe
Compare
cmd/openshift-install/testdata/agent/pxe/configurations/compact_external.txt
Outdated
Show resolved
Hide resolved
|
/lgtm |
When creating an Agent ISO for OCI, add the kernel argument console=ttyS0 to the ISO/PXE kargs. CoreOS does not include a console arg by default when using metal as the platform because different hardware has different consoles and specifying one can cause booting to fail on some, but it does on many cloud platforms. Since we know when the user is definitely using OCI and we know the correct settings for OCI, we should set them up automatically. Signed-off-by: Pawan Pinjarkar <ppinjark@redhat.com>
pawanpinjarkar
force-pushed
the
enable-console-on-oci
branch
from
7c13bfe
to
4b7a664
Compare
|
/retest-required |
1 similar comment
|
/retest-required |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rwsu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/test agent-integration-tests |
|
Integration test failure looks... persistent: https://prow.ci.openshift.org/pr-history/?org=openshift&repo=installer&pr=7511 |
|
/hold Revision 4b7a664 was retested 3 times: holding |
openshift-ci
bot
added
the
do-not-merge/hold
|
@pawanpinjarkar: This pull request references Jira Issue OCPBUGS-19092, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest-required |
|
@pawanpinjarkar: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
openshift-merge-robot
merged commit 80866ab
into
openshift:master
|
@pawanpinjarkar: Jira Issue OCPBUGS-19092: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-19092 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Fix included in accepted release 4.15.0-0.nightly-2023-09-30-045436 |
|
/jira cherrypick OCPBUGS-19092 |
|
@pawanpinjarkar: Jira Issue OCPBUGS-19092 has been cloned as Jira Issue OCPBUGS-20345. Will retitle bug to link to clone. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
changed the title
|
@pawanpinjarkar: Jira Issue OCPBUGS-20345: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-20345 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.14 |
|
@pawanpinjarkar: #7511 failed to apply on top of branch "release-4.14": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
When creating an Agent ISO for OCI, add the kernel argument
console=ttyS0to the ISO/PXE kargs.CoreOS does not include a console arg by default when using metal as the platform because different hardware has different consoles and specifying one can cause booting to fail on some, but it does on many cloud platforms. Since we know when the user is definitely using OCI and we know the correct settings for OCI, we should set them up automatically.
Signed-off-by: Pawan Pinjarkar ppinjark@redhat.com
@pawanpinjarkar